Forums

Simultaneous Edits by Different Users

Permalink
Hey, folks.

I've recently run into an issue with my 5.7.5.3 installation. Two members of my user community entered edit mode on the same document. They were both able to make edits to the same block and save the block. The user who saved last had their edits retained, while the user who saved first discovered their edits missing afterward. A colleague and I were able to replicate this behavior on a test page.

In a previous installation I had (5.4.2.2) on a different server, users were unable to enter edit mode when another user had a page "checked out."

Has anyone else run into this issue? Am I missing some application or extension on my server? Any suggestions how to correct this behavior?
campbell
 
tallacman replied on at Permalink Reply
tallacman
Never heard of that but updating the core may fix it.
campbell replied on at Permalink Reply
campbell
Well, I've updated our system to versoin 5.7.5.9, and we're still seeing that behavior.

I went digging a little and found that in the concrete\elements\page_controls_footer.php file, there is this following code:

<?php if ($pageInUseBySomeoneElse) { ?>
        <?php echo Core::make('helper/concrete/ui')->notify(
            array(
                'title'   => t('Editing Unavailable.'),
                'message' => t("%s is currently editing this page.", $c->getCollectionCheckedOutUserName()),
                'type'    => 'info',
                'icon'    => 'exclamation-sign'
            )) ?>


I've never seen this dialog appear in my setup, and I have definitely seen two users editing a page at the same time since I upgraded the core.

I don't understand why this dialog wouldn't appear.
JohntheFish replied on at Permalink Best Answer Reply
JohntheFish
There is an environment dependant bug to do with edit mode detection on 5.7 up to 5.7.5.9. It often shows up for blocks with different edit mode views (galleries, maps) rendering the view rather than the edit mode during editing.

What you describe sounds as if it could easily be a manifestation of that bug.
https://github.com/concrete5/concrete5/issues/4521...
https://github.com/concrete5/concrete5/issues/3930...

If you are wary of upgrading to v8, the fix should be in place in the latest 5.7.5.xx
campbell replied on at Permalink Reply
campbell
Thanks, JohntheFish.

We still need to upgrade our PHP to 5.6+, so upgrading to v8 isn't yet possible, but I can try upgrading to 5.7.5.13 and see if that fixes the issue.

I'll report back.
JohntheFish replied on at Permalink Reply
JohntheFish
Backup first. Upgrades glitching are often a source of grief.
campbell replied on at Permalink Reply
campbell
John, thanks for the update. We've upgraded to version 5.7.5.13, and we have user collision functionality once more. Much appreciated!