After updating to 5.6.0.2 the homepage was broken

Permalink
I just updated a customers c5 site from 5.5.2.1 to 5.6.0.2 and post upgrade the homepage of the website was only 50% displaying. The editing toolbar was also not displayed. Site using Simple Permissions.

I could access the /dashboard page and access other pages which displayed ok.

After some fiddling about I commented out

<?php define('DIRNAME_APP_UPDATED', 'concrete5.6.0.2');?>

to
<?php /*define('DIRNAME_APP_UPDATED', 'concrete5.6.0.2')*/;?>


and now the site works again!

Does this make any sense and am I safe to leave this line commented out?

cytringan
 
Remo replied on at Permalink Reply
Remo
a missing toolbar sounds like a missing footer_required in the footer.php of your theme

<?php Loader::element('footer_required'); ?>
cytringan replied on at Permalink Reply
cytringan
1st thing I checked:

view.php and default.php (no other page types)
$this->inc('elements/header.php'); ?>


elements/header.php
<html>
<head>
<?php  Loader::element('header_required'); ?>
</head>
<body>


and

view.php and default.php (no other page types)
<?php  $this->inc('elements/footer.php'); ?>


elements/header.php
<?php  Loader::element('footer_required'); ?>
</body>
</html>
cytringan replied on at Permalink Reply
cytringan
Let me also add the classic line "it was working ok before the update"
Remo replied on at Permalink Reply
Remo
My theory would have worked as footer_required wasn't required before ;-) It has been moved from the header to the footer and therefore would have explain the missing toolbar.

In this case I only have a number of different things I'd personally try: Clear the cache, change to a different theme to see if it's within the theme, disable some add-ons etc.
cytringan replied on at Permalink Reply
cytringan
Yep, did all of the above. I even read some pages of a book by a guy called "Remo" to check I wasn't crazy.... :-)

I'm thinking the issue lies in the way DIRNAME_NAME_UPDATED is appended to the site.php file, but that's just a gut feeling and no real evidence to prove it.

I'll make a another update to 5.6 to another customer site later this week and see if I get a similar issue.

Thanks for your comments
Remo replied on at Permalink Reply
Remo
Good to know ;-) It's sometimes a bit tricky to know how much php, c5 experience someone in the forum has.

I don't think DIRNAME_APP_UPDATED should cause any problem. It might look a bit odd since that line is appended by code. The result could look like this:

<?php
define...
?>
<?php define('DIRNAME_APP_UPDATED', '');?>


That's fine, but if you want, you could also remove some of it and make it look like this:

<?php
define...
define('DIRNAME_APP_UPDATED', '');?>


You could also copy the core from /updates/.... to /concrete if you wanted to replace the old data completely.

I wouldn't recommend to do what you're doing. If you comment out that line you'll use the core files of 5.5 and have a database you updated to 5.6. As a matter of fact I'm surprise that you don't get any errors!

I would have checked if the upgrade process has been executed successfully. You can do that by navigating to index.php/tools/required/upgrade
ConcreteOwl replied on at Permalink Reply
ConcreteOwl
Most likely explanation is that the upgrade to 5.6 failed and the database is still running on 5.5.2.1
This would explain why commenting out the "UPDATED" definition worked,
I have had two sites running on different hosts with exactly the same results, (upgrades from 5.5.2.1 to 5.6.0.2 that failed)
At the moment I am waiting for 5.6.0.3 to be released before trying again..
cytringan replied on at Permalink Reply
cytringan
With the DIRNAME_APP_UPDATED line comment out the update page says this:


Upgrade concrete5

Upgrading from 5.6.0.2
Upgrading to 5.5.2.1

Your current website uses a version of Concrete5 greater than this one. You cannot upgrade.


When I ran the update it seemed ok, I got some type of successful message at the end.
I did also check the php and webserver logs, but nothing to notice there.

Is there a way to manually check if the DB and CORE made it to 5.6?
cytringan replied on at Permalink Reply
cytringan
At the bottom of the update screen there was a link - something like "click here to re-run this script". I clicked it and now the update page reports:


Install Local Update
Make sure you backup your database before updating.

An update is available. Click below to update to 5.6.0.2.
Current Version 5.5.2.1


I'll re-run that update later today and watch record all the info, see if I can catch what goes wrong for me.

Thanks for all your great responses so far