How to install Hot Fix

Permalink
Hi all,
I have an issue which I found in the bug tracker and also I found a solution in Github.
So my question is, how do I install a hotfix from github.
What I did is, I downloaded the php files mentioned in the hotfix and copied them to the respective folder under .../concrete/.....
In addition I also cleared all caches.
But the problem still exists.
So my question is, did I do something wrong?
Do I need an additional step?
Thank you for any hint...
Gruß
Johannes

View Replies: View Best Answer
ramonleenders replied on at Permalink Reply
ramonleenders
Not sure what the issue is, but it could be it was related to another change of code (which wasn't in that same commit/fix).
JPa replied on at Permalink Reply
OK, thank you!
So I did the right thing to install the fixed.
Now I need to recheck whether I selected the right files.
Thank you!
Gruß
Johannes
Gondwana replied on at Permalink Reply
Gondwana
As I understand it, github commits aren't hotfixes. They're changes to make a whole new version of c5. By taking some files from a github branch and dropping them into your current installation, you're risking other incompatibilities because the github files may have other changes that depend on other github files that you're not getting.

The safest way to have a 'pure' installation that includes a github commit is to install that whole github branch. Since you're probably talking about the develop branch, that's risky because it isn't stable.
weyboat replied on at Permalink Best Answer Reply
weyboat
If you have upgraded your concrete5 version, you could be running your site out of the updates folder in which case you should make the changes to the concrete files in that location since your root/concrete folder is being over-ridden.
JPa replied on at Permalink Reply
@Gondwana
Thank you!
Yes I found out after considering the comment of weyboat.
System behaves "funny" now...
As I read from github some specific changes to 4 files have been made.
According tohttps://github.com/concrete5/concrete5/pull/5840/files... 4 files were changed and I had hoped that the files there just contained those changes.
But there seem to be more changes in these files.
So I will try to edit the files manually...
Gruß
Johannes
JPa replied on at Permalink Reply
@weyboat
Thank you!
That made the change!
I had installed into the original "concrete" folder.
System behavior changed.
"Surgery successful --> patient dead" :-)
But now I know what the process is...
weyboat replied on at Permalink Reply
weyboat
You are welcome.
Its an easy mistake to make, I have tripped up a few times myself with that one!