top toolbar issue

Permalink 2 users found helpful
Hi!

I'm having a go at a 5.7 theme but im running into the following issue:
the top toolbar, it shows but once i click one of the options (dashboard or page attributes) then a top margin appears and when i click on page attributes it does not let me go back to the page itself without reloading. im following andrews tutorial on themes but i cannot find anything there that im not doing by the book, any help is appriciated!

1 Attachment

xb385
 
MrKDilkington replied on at Permalink Reply
MrKDilkington
Hi xb385,

Double check your code to make sure you have this and the closing </div> tag.
<div class="<?php echo $c->getPageWrapperClass(); ?>">
xb385 replied on at Permalink Reply
xb385
thx for the reply, i wish it was that simple :)
WebcentricLtd replied on at Permalink Reply
if you use Chrome and look at the element inspector are there any clues there? The issue looks like you have an element breaking outside of the page wrapper class. Do you have anything lower in your page that breaks outside of the grid - might just be an extra closing div in the wrong place...that's where I'd look first anyway.
xb385 replied on at Permalink Reply
xb385
the code i posted is all i have, ill have another check for that, maybe even remove some elements and check again.
could it be that an added layout added via page edits is whats causing this?
WebcentricLtd replied on at Permalink Reply
there is most likely (but not definitely) something wrong in your theme.

To start to troubleshoot these kind of issues I would generally open the webpage in chrome and then click on the menu icon in the right-hand side of the toolbar

and then select

more tools > developer tools

by default this opens a new window that shows the element inspector.

You can use the left-hand pane to click on the various page elements to see them highlighted in the main browser window and with a detailed breakdown in the right panel of the new inspector window.

If you go through this it gives you much more information than the source as you can actually visualise how your browser is building the page from your source code.

At some point when you are clicking onto the various elements you 'might' find the rogue one that is altering your layout.
marmalade replied on at Permalink Best Answer Reply
marmalade
Hi Kurt,

I had this exact same issue and I can see from the code you posted you made the same mistake I did.

The Concrete5 footer element needs to be AFTER the closing Concrete5 wrapper div (i.e put the footer element just before the /body tag).

Simple as that for me at least.

Cheers,
Jon.
xb385 replied on at Permalink Reply
xb385
That was it! awesome, thx allot for the help!

for people having the same issue in the future REMEMBER keep your header/footer required out of your pagewrapper!

<!DOCTYPE html>
   <html>
      <head>
              <?php loader::element('header_required'); ?>
         <!-- your css etc -->
      </head>
      <body>
         <div class="<?php echo $c->getPageWrapperClass()?>">
      <!-- your page code -->            
         </div>
       <?php loader::element('footer_required'); ?>
      </body>
   </html>