Resolved Bug


This bug has been marked as resolved.

Link nesting/closing bug when non-admins put toolbar into 'editing' mode

Permalink 0 0 Browser Info Environment
Just submitted a pull in Github:
https://github.com/concrete5/concrete5/pull/446...

Spotted that non-admins (or, rather, editors with edit access to pages but not to access the dashboard) were having alignment/incorrect icon issues on the live search field when editing a page. Turns out that the <a> link wasn't being correctly closed for people without full dashboard access, causing the <a> to encompass the search field on the right hand side of the toolbar. Basically pushed the search input field down and right a good number of pixels and added a button highlight and incorrect 'edit' pencil icon to the search field area.

A little off-putting and could cause weird behaviour with javascript and CSS due to the dodgy nesting and JS triggers on incorrect elements.

See attached for example.

Fixed in the pull request above.

1 Attachment


Status: Resolved
arcanepain
arcanepain replied on at Permalink
arcanepain
Andrew has merged in GitHub! Closing.

concrete5 Environment Information

-

Browser User-Agent String

Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/535.11 (KHTML, like Gecko) Chrome/17.0.963.46 Safari/535.11