Invalid html on Guestbook/Comments block.

Permalink 0 0 Browser Info Environment
Call me pedantic but the form elements in this block are incorrectly formed, the 'for' attribute on the label tags should refer to an id not the name. The following works: -

<?php  if(!$controller->authenticationRequired){ ?>
            <label for="guestBook-formBlock-<?php echo $controller->bID?>-name"><?php echo t('Name')?>:</label><?php echo (isset($errors['name'])?"<span class=\"error\">".$errors['name']."</span>":"")?><br />
            <input type="text" name="name" value="<?php echo $Entry->user_name ?>" id="guestBook-formBlock-<?php echo $controller->bID?>-name" /> <br />
            <label for="guestBook-formBlock-<?php echo $controller->bID?>-email"><?php echo t('Email')?>:</label><?php echo (isset($errors['email'])?"<span class=\"error\">".$errors['email']."</span>":"")?><br />
            <input type="email" name="email" value="<?php echo $Entry->user_email ?>" id="guestBook-formBlock-<?php echo $controller->bID?>-email" /> <span class="note">(<?php echo t('Your email will not be publicly displayed.')?>)</span> <br />
         <?php  } ?>

Also I'm pretty sure the following line is superfluous (and also invalid HTML): -
<a name="guestBookForm-<?php echo $controller->bID?>"></a>

although the form itself is unnamed, looks like someone has moved it for safekeeping and forgotten about it.

The same is true of the CAPTCHA validation helper.
Status: New
View Replies:

concrete5 Environment Information

# concrete5 Version

# concrete5 Packages
AddThis (1.0), Box Grabber (1.3), Color Picker Attribute (1.0), Content+ (0.9.0), howtobet4free files (1.6), Internationalization (1.1.2), Lightboxed Image (0.9.2).

# concrete5 Overrides

# Server Software

# Server API

# PHP Version

# PHP Extensions
bcmath, bz2, calendar, cgi-fcgi, Core, ctype, curl, date, dom, ereg, exif, fileinfo, filter, ftp, gd, gettext, gmp, hash, iconv, imap, intl, ionCube Loader, json, ldap, libxml, mbstring, mcrypt, mssql, mysql, mysqli, mysqlnd, OAuth, odbc, openssl, pcntl, pcre, PDO, pdo_mysql, PDO_ODBC, pdo_pgsql, pdo_sqlite, pgsql, posix, readline, Reflection, session, shmop, SimpleXML, soap, sockets, SPL, SQLite, sqlite3, standard, sysvmsg, sysvsem, sysvshm, tokenizer, wddx, xml, xmlreader, xmlrpc, xmlwriter, xsl, Zend Guard Loader, zip, zlib.

# PHP Settings
log_errors_max_len - 1024
max_execution_time - 5
max_file_uploads - 20
max_input_nesting_level - 64
max_input_time - 60
max_input_vars - 1000
memory_limit - 128M
post_max_size - 64M
safe_mode - Off
safe_mode_exec_dir - <i>no value</i>
safe_mode_gid - Off
safe_mode_include_dir - <i>no value</i>
sql.safe_mode - Off
upload_max_filesize - 64M
ldap.max_links - Unlimited
mssql.max_links - Unlimited
mssql.max_persistent - Unlimited
mssql.max_procs - Unlimited
mssql.textlimit - Server default
mysql.max_links - Unlimited
mysql.max_persistent - Unlimited
mysqli.max_links - Unlimited
mysqli.max_persistent - Unlimited
odbc.max_links - Unlimited
odbc.max_persistent - Unlimited
pcre.backtrack_limit - 1000000
pcre.recursion_limit - 100000
pgsql.max_links - Unlimited
pgsql.max_persistent - Unlimited
session.cache_limiter - nocache
session.gc_maxlifetime - 7200
soap.wsdl_cache_limit - 5
safe_mode_allowed_env_vars - PHP_
safe_mode_protected_env_vars - LD_LIBRARY_PATH

Browser User-Agent String

Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/535.19 (KHTML, like Gecko) Chrome/18.0.1025.142 Safari/535.19