controller tasks on home page not working

Permalink 50 49 Browser Info Environment
Tracking issue
http://www.concrete5.org/developers/bugs/5-6-1/controller-tasks-on-...
After closing
https://github.com/concrete5/concrete5/pull/850...

Would love to have a nice happy way to make this work.


Status: Major
Remo
Remo replied on at Permalink Reply
Remo
Hey Mike
I wonder what kind of approach you've got in mind. You said you don't want to let the controller make that decision (404 or not).
As far as I see it, this is the only way. The request object cannot know whether a page (+method) actually exists or not. Only the controller has that kind of knowledge due to which I don't see any other approach.
If you think my code will break something, let me know what and I'll run some more tests. My code is in use on every project we've built during the last 6 months. We deploy more than just one site per month...
Thanks!
Remo
Remo replied on at Permalink Reply
Remo
Hey Mike, any news on this? I still don't have any clue how you'd want to fix this without including the controller, seems pretty much impossible.

While I agree that forwarding calls to the controller is a bit ugly, this already happens, not at such an excess at it would with my pull requests, but it happens. And besides, having this bug in the core is definitely the ugliest thing!
Remo replied on at Permalink Reply
Remo
Mike, as discussed by mail. Here's the updated pull request which would make sure the existing method getRequestedPage doesn't change:

https://github.com/concrete5/concrete5/pull/1249...

concrete5 Environment Information

.

Browser User-Agent String

Mozilla/5.0 (X11; Linux x86_64; rv:25.0) Gecko/20130628 Firefox/25.0