Fatal PHP Error in SelectAttributeTypeController::searchForm

January 31, 2011 at 1:55 PM Permalink 0

I haven't debugged how it happened we had a product with a select attribute option that didn't exist. The SelectAttributeTypeController::searchForm method was failing with a fatal error because the option object was invalid.

The following code:

foreach($options as $id) {
  if ($id > 0) {
    $opt = SelectAttributeTypeOption::getByID($id);
    $optionText[] = $opt->getSelectAttributeOptionValue();
  }
}

should be changed to:

foreach($options as $id) {
  if ($id > 0) {
    $opt = SelectAttributeTypeOption::getByID($id);
    if (is_object($opt)) {
      $optionText[] = $opt->getSelectAttributeOptionValue();
    }
  }
}