Swapped variables in remove_old_page_versions job. (version 8.3.2)

Permalink 0 0 Browser Info Environment
I was just running the remove_old_page_versions job, and noticed that it seemed to be returning an incorrect message upon completion. I looked at the php file, and noticed this section:

//i18n: %1$d is the number of versions deleted, %2$d is the number of affected pages, %3$d is the number of times that the Remove Old Page Versions job has been executed.
        return t2(
            '%1$d versions deleted from %2$d page (%3$s)',
            '%1$d versions deleted from %2$d pages (%3$s)',
            $pageCount,
            $versionCount,
            $pageCount,
            implode(',', $pagesAffected)
        );


The $pageCount and $versionCount variables are swapped, so instead of saying for example "x versions removed from 3 pages." it always says "3 versions removed from x pages." It also seems like $pageCount is passed twice, but I don't believe this should be the case?

Minor bug, but still figured I'd report it, since I didn't see it in any existing bug reports.


Status: New

concrete5 Environment Information

# concrete5 Version
Core Version - 8.3.2
Version Installed - 8.3.2
Database Version - 20180122213656

# concrete5 Packages
HTML+PHP Code Block (1.0.1), Supermint Theme (3.4.1.3)

# concrete5 Overrides
blocks/autonav/templates/supermint_dropdown.php, blocks/autonav/templates, blocks/autonav, controllers/single_page/dashboard/gkm_management/view.php, controllers/single_page/dashboard/gkm_management/general.php, controllers/single_page/dashboard/gkm_management, controllers/single_page/dashboard, controllers/single_page, js/jquery.js, single_pages/dashboard/gkm_management/view.php, single_pages/dashboard/gkm_management/general.php, single_pages/dashboard/gkm_management, single_pages/dashboard

# concrete5 Cache Settings
Block Cache - Off
Overrides Cache - Off
Full Page Caching - Off
Full Page Cache Lifetime - Every 6 hours (default setting).

# Server Software
LiteSpeed

# Server API
litespeed

# PHP Version
7.1.16

# PHP Extensions
bcmath, bz2, calendar, Core, ctype, curl, date, dba, dom, enchant, exif, fileinfo, filter, ftp, gd, gettext, gmp, hash, iconv, imap, intl, json, libxml, litespeed, mbstring, mcrypt, mysqli, mysqlnd, odbc, openssl, pcre, PDO, pdo_mysql, PDO_ODBC, pdo_pgsql, pdo_sqlite, pgsql, Phar, posix, pspell, Reflection, session, shmop, SimpleXML, soap, sockets, SPL, sqlite3, standard, sysvmsg, sysvsem, sysvshm, tidy, tokenizer, wddx, xml, xmlreader, xmlrpc, xmlwriter, xsl, zip, zlib

# PHP Settings
max_execution_time - 30
log_errors_max_len - 1024
max_file_uploads - 20
max_input_nesting_level - 64
max_input_time - 60
max_input_vars - 1000
memory_limit - 256M
post_max_size - 8M
sql.safe_mode - Off
upload_max_filesize - 2M
mysqli.max_links - Unlimited
mysqli.max_persistent - Unlimited
odbc.max_links - Unlimited
odbc.max_persistent - Unlimited
pcre.backtrack_limit - 1000000
pcre.recursion_limit - 100000
pgsql.max_links - Unlimited
pgsql.max_persistent - Unlimited
session.cache_limiter - <i>no value</i>
session.gc_maxlifetime - 7200
soap.wsdl_cache_limit - 5

Browser User-Agent String

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36