php7.2
Permalink Browser Info Environment
For php7.2, I have made the below changes to packages/formidable/models/formidable/form.php
public function countResults($by = '', $value = '', $return = false) { $this->submissions = 0; $db = Loader::db(); $q = "SELECT COUNT(answerSetID) AS total FROM FormidableAnswerSets WHERE formID = ? AND temp != 1"; if ($by != '' && $value != ''){ $q .= " AND ? = ?"; $data = $db->getOne($q, array($this->formID, $by, $value)); } else { $data = $db->getOne($q, array($this->formID)); } if ($data)
Viewing 15 lines of 40 lines. View entire code block.
Type: | Pre-Sale |
---|---|
Status: | In Progress |
The c5.6.4 code on GitHub takes care of php7.2 for the core. The main addon with issues is eCommerce. I have listed changes needed for eComemrce athttps://www.c5magic.co.uk/add-ons/zone-based-shipping/php7/....
Unfortunately Portland Labs are no longer supporting eCommerce and the license prevents me from simply posting an updated zip.
I have been fixing php7.2 compatibility with my addons as and when, so most are now compatible.
The main areas for glitches are:
- parameter mismatches (that 7.2 complains about),
- 'Object' now being a reserved word,
- deprecated functions such as mcrypt disappearing
I haven't tested all of Formidable, just enough for the forms a customer site was using.
Unfortunately Portland Labs are no longer supporting eCommerce and the license prevents me from simply posting an updated zip.
I have been fixing php7.2 compatibility with my addons as and when, so most are now compatible.
The main areas for glitches are:
- parameter mismatches (that 7.2 complains about),
- 'Object' now being a reserved word,
- deprecated functions such as mcrypt disappearing
I haven't tested all of Formidable, just enough for the forms a customer site was using.
We did use 5.6.4 and it seems to work. We also found those issues you mentioned and fixed those where we could.
Are you doing this work to keep "older" customers on C5.6? Or are you having doubts about C8?
Are you doing this work to keep "older" customers on C5.6? Or are you having doubts about C8?
Mainly for old 5.6 customers who don't want a complete redevelopment.
v8 is pretty good for most new projects, but every now and then there is a project where 5.6.4 is a better fit. c5.6.4 is 1/4 the size of v8, is faster out of the box, fits better on small shared host accounts with limited resources, installs more reliably, is stable, has the old eCommerce, and is much easier for garden-shed developers to get to grips with.
I can also get 5.6 running on an Asustor NAS or Raspberry Pi. Neither can cope with the bloat of v8 ;-)
v8 is pretty good for most new projects, but every now and then there is a project where 5.6.4 is a better fit. c5.6.4 is 1/4 the size of v8, is faster out of the box, fits better on small shared host accounts with limited resources, installs more reliably, is stable, has the old eCommerce, and is much easier for garden-shed developers to get to grips with.
I can also get 5.6 running on an Asustor NAS or Raspberry Pi. Neither can cope with the bloat of v8 ;-)
Hi - thanks for the patch. I tried it on 5.6.4.0 PHP 7.3 but it still doesn't work. On the error log, I see warnings but no errors. The error shows up on the actual installation/webpage as:
An unexpected error occurred.
An error occurred while processing this request.
< Back to Home
Is there a new fix for this?
Thanks!
An unexpected error occurred.
An error occurred while processing this request.
< Back to Home
Is there a new fix for this?
Thanks!
Thank you!
Do you have a lot of issues to get 5.6 working on php7?
We are also updating as we speak.
Best,
Corretje