Forums

Close button missing

Permalink
I have a strange issue with a local site I'm developing where the close button is missing from the newsflow and help overlay.

It doesn't seem to be a css conflict as I'm using a pagewrapper class and namespacing the css.

When I inspect the code in the local the close button markup is:

<button type="button" class="ui-dialog-titlebar-close"></button>


If I compare to another install with the close button showing the markup should be:

<button type="button" class="ui-button ui-widget ui-state-default ui-corner-all ui-button-icon-only ui-dialog-titlebar-close" role="button" title="Close"><span class="ui-button-icon-primary ui-icon ui-icon-closethick"></span><span class="ui-button-text">Close</span></button>


Anyone know what could be going on? I'm using 5.7.5.5
1976Ltd
 
andrew replied on at Permalink Reply
andrew
I would guess you're using a custom build of jQuery UI for some reason and
it's causing problems
1976Ltd replied on at Permalink Reply
1976Ltd
Thanks for pointing me in the right direction Andrew.

Turns out it's bootstrap javascript which I'm providing in my site footer include and letting Concrete know not to include it again via page_theme.php

$this->providesAsset('javascript', 'bootstrap/*');


From what I've read in the documentation this is the correct method but I'm getting this conflict. If I remove that line from page_theme.php then the close button appears but then my theme can't use the bootstrap js.
1976Ltd replied on at Permalink Reply
1976Ltd
I still have this issue, has anyone else got a working version of a theme which provides it's own bootstrap.min.js which doesn't remove the close button for the C5 modals for Newsflow and Help?

It's a pretty minor thing but we are supposed to be able to use:

$this->providesAsset('javascript', 'bootstrap/*');
without it breaking the core UI.