GridFramework for Zurb's Foundation - When?

Permalink
Hi,

Just bought the Fundamental theme and began to think about convert an old site to 5.7. But as of now Zurb's Foundation is not part of the GridFramework for 5.7.

We actually thought about making a theme our selves using Zurb's Foundation, but...

Any idea about when you are adding Zurb's Foundation to the GridFramework?

/Michael

maar
View Replies:
Shotster replied on at Permalink Reply
Shotster
I don't know if this helps you or not, but are you aware of the following...

https://github.com/core77/foundation_sites...

-Steve
maar replied on at Permalink Reply
maar
Hi,

I am totally aware of this. That was not the question. Concrete5 5.7 ships with 3 core GridFramework settings (Bootstrap2, Bootstrap3 and NineSixty). They are there, as I understand, to themes to be able to use some of the core settings correctly. Such as layouts on pages. If you install a theme with fx. bootstrap3 ant the theme tells the core that it is bootstrap3. Then the core will supply fx. layouts with the correct column width according to the theme framework.

/Michael
Shotster replied on at Permalink Reply
Shotster
Ok, no worries. Sorry. I haven't messed with the new 5.7 grid stuff much myself yet.

-Steve
MrKDilkington replied on at Permalink Reply
MrKDilkington
Have you checked out this thread?
http://www.concrete5.org/community/forums/5-7-discussion/adding-cus...

I don't use Foundation, so I can't be sure - but I looked at the Foundation grid info page and it looks similar enough to convert using BootStrap3.php as an example.

I don't think Foundation uses containers, so this could be removed.
https://github.com/concrete5/concrete5-5.7.0/blob/4ff13b977e3fe9da58...

Replace the Bootstrap grid classes with the Foundation grid classes.
https://github.com/concrete5/concrete5-5.7.0/blob/4ff13b977e3fe9da58...

public function getPageThemeGridFrameworkColumnClasses()
    {
        $columns = array(
            'small-1 columns',
            'small-2 columns',
            'small-3 columns',
            'small-4 columns',
            'small-5 columns',
            'small-6 columns',
            'small-7 columns',
            'small-8 columns',
            'small-9 columns',
            'small-10 columns',
            'small-11 columns',
            'small-12 columns'


Replace the Bootstrap3 offsets with the Foundation offsets.
https://github.com/concrete5/concrete5-5.7.0/blob/4ff13b977e3fe9da58...

public function getPageThemeGridFrameworkColumnOffsetClasses()
    {
        $offsets = array(
            'small-offset-1',
            'small-offset-2',
            'small-offset-3',
            'small-offset-4',
            'small-offset-5',
            'small-offset-6',
            'small-offset-7',
            'small-offset-8',
            'small-offset-9',
            'small-offset-10',
            'small-offset-11',
            'small-offset-12'
core77 replied on at Permalink Reply
Hi. Developer docs should be released very shortly. So I think it's not gonna be that hard to integrade the Foundation for Sites grid.

Without docs it's not so funny ;-)
core77 replied on at Permalink Reply
Nice: "As of 5.7.2.1, it's included with the core as well."
MrKDilkington replied on at Permalink Reply
MrKDilkington
Expanding on what core77 posted.

https://github.com/concrete5/concrete5-5.7.0/blob/75d85fb56d94404d21...

I wonder if these two methods are new.
andrew replied on at Permalink Reply
andrew
They are indeed. I sat down to do the docs and thought it might be nice to do them with Zurb Foundation as the example, since it's popular. Heh, took a little longer than anticipated, since we needed to tweak the core to make it work fully (adding those methods, etc...)
maar replied on at Permalink Reply
maar
Hi Andrew,

Thanks.. Appreciated...

/Michael
OKDnet replied on at Permalink Reply
OKDnet
+1
maar replied on at Permalink Reply
maar
Hi,

Since 5.7.2.1 that include the GridFrame for fountation, I really tried to make it work bot just seem to fail. Actually the GridFramework is there and it works when you add a layout. But it is only using css classes for "small-x" and not "medium-x and "large-x". That is actually not making foundation work responsive.

I really tried to find a way, but no luck. It seem to me that the core GridFramework is too simple to fully support Zurbs Foundation framework. The "getPageThemeGridFrameworkColumnClasses" function is simply not enough.

Right now the only solution to this is not to use "Layouts" on pages, but simply add new page templates to the theme. That way you will get it to work.

Is there any plans to get this to work. It is realy not fair to the customers that buy a Foundation Theme on the marketplace and find them selves not having a fully responsive theme.

/Michael
andrew replied on at Permalink Reply
andrew
We're changing the classes to be medium-* instead of small-* in 5.7.2.2 so it will actually collapse properly on small devices rather than just stay tiny columns.
maar replied on at Permalink Reply
maar
Thanks, I just tried that and it seem to work.

Hopefully it will be better in future versions.

/Michael