Override model of a package
I wanna override a model of a package. I've put the modified file in the models-directory, but nothing happens. Unfortunately I didn't find a solution in the forum or elsewhere...
Does anybody have an idea?
Thanks and regards,
So if it's packages/jshare/models/model_name.php
you'll copy to
I think it's one of those things that will (hopefully) get slowly fixed over time. I've seen quite a few pull requests on github (and have made one or two myself) related to fixing these inconsistencies in the past few months.
(We just need Andrew to accept them :)
Regarding the inconsitencies and pull-requests.
I think Andrew has his own quality guidelines and they might not be the same as for the marketplace. Which I think are basic standards compared to what you need to keep an eye for when you commit to the core. I think we both should know it best, because working in open-source projects often results in low quality commits if you don't have some quality assurance or high standards. Accepting every little push-request could look like progress to someone who tries to free a queue, but I think that's the way you can unknowingly inject exploits, bugs, low quality code and inconsistencies. Many opensource projects suffer from such problems. See apache, vsftpd, hadoop.. However assuring quality over a long period of time is very hard compared to working in a local team, I guess Andrew can verify that one. I guess the worst that could happen to c5 is when Microsoft would try to send their backdoor pull-requests ;)
I know you're a very experienced developer and your commits take a high standard, but everyone else can commit too.
I totally agree with everything you said though, I know it's not the best idea to blindly pull in everything.
Probably shouldn't have bothered with my above comment, it's just that the override inconsistencies are a perpetual thorn in my side on my own projects. (But again I am not laying blame on anyone for this, I know it's a complex system and takes time to work out all the kinks).