Can't resolve conflict with edit bar

Permalink
I have successfully gone through many of the initial steps to converting a template into a theme.
Basically, the edit bar is some distance from the top of the page and it ends up covering my first editable region. (see attached screenshot)

edit: I located the following code in page_controls_header.php and commented it out thinking that it was the issue. I realize now that this code: <style type="text/css">html {margin-top: 49px !important;} </style> pushes the content below the edit bar. So, I am still at a loss as to why there is space above the edit bar.

I have gone through and created a div in the body. The div has an id= themeWrapper that encloses the entirety of the content. I have also appended #themeWrapper to almost every css style in all of the attached sheets. I have also attached a screenshot of the generated source code to show what i have going on.

any advice would be appreciated.

2 Attachments

 
CMSDeveloper replied on at Permalink Best Answer Reply
CMSDeveloper
Hi!

The css code "margin-top: 49px !important;" is a standard concrete5 css rule for the edit bar:
/concrete/elements/page_controls_header.php
Rule number : 13
"<style type="text/css">html {margin-top: 49px !important;} </style>"

I do think you leave this file as it is, and edit your theme css file that's responsible for the gap!

Kind Regards
CMSDeveloper replied on at Permalink Reply
CMSDeveloper
btw it's not so easy to convert a template to a concrete5 theme.

Did you think about to buy a theme?

Did look similar to what you now use:

http://themes.formigo.co.uk/?theme=Alpha...

;)
envisionschools replied on at Permalink Reply
Thank you. I had not found that theme. I think it actually looks so much more complete than the one I am working on would be if I did get it to work. I am very new to Concrete5 but I love the way it works. It seems that the learning curve will eventually be worth it.

Best,
Rob
neopixel replied on at Permalink Reply
neopixel
Im going through much the same trials and tribulations converting my bootstrap based HTML into a C5 theme.

One thing I did find is that C5 loads the jquery library by default.

Leaving my own call in does weird things to the admin nav bar.

Remove it and everything works just fine :)

Maybe that's why your admin bar was doing strange things?!?
juddc replied on at Permalink Reply
juddc
Looks like you're loading jquery twice - Comment out line 10 in your html and then clear the cache in the Dashboard Settings and see if that fixes it.

C5 loads up jquery on its own, so chances are thats where the weirdness is coming from. Let us know if that helps!