different file download path in global area for every page

Permalink
Hi guys,

during SEO optimization I noticed following:
I put a link to a file (via tinyMCE -> add file) in a global area in page footer.
The download link (e.g. mywebsite/index.php/download_file/view/239/144/) is different (the numbers at the end) on most pages of the site.
After scanning the site, the SEO-Tool showed me 40 redirects with HTTP Status: 302 for this file in footer.

Is it a bug or why changes the path on different pages?


Regards

Torsten

tsilbermann
 
nebuleu replied on at Permalink Reply
nebuleu
The second number is the cID of the current page, but I don't know why it is added. Probably for the stats ?
tsilbermann replied on at Permalink Reply
tsilbermann
The first number is always the same (239) If the second is the page ID - why do they appear?
nebuleu replied on at Permalink Reply
nebuleu
The first number is the file number, the only really useful.
The cID number seems used when the file is password protected.


Details:

1) The download link with the cID is created by:
https://github.com/concrete5/concrete5/blob/master/web/concrete/core...

2) And the controller used is:
https://github.com/concrete5/concrete5/blob/master/web/concrete/core...

3) In the view, the cID is used in the case of the file is protected by a password, in a hidden field:
https://github.com/concrete5/concrete5/blob/master/web/concrete/sing...

4) And finally the cID is used by the submit_password in the controller:
https://github.com/concrete5/concrete5/blob/master/web/concrete/core...
nebuleu replied on at Permalink Reply
nebuleu
Oh, and I was right in my first thought, the cID is used also for tracking stats download in the controller, with the

https://github.com/concrete5/concrete5/blob/master/web/concrete/core...
https://github.com/concrete5/concrete5/blob/master/web/concrete/core...

The trackDownload function in the File object :
https://github.com/concrete5/concrete5/blob/master/web/concrete/core...

If no cID is provided, 0 is used in the stats.
tsilbermann replied on at Permalink Reply
tsilbermann
Thanks for your help :)
Maybe its possible to use "SEO friendly URLs" (as a suggestion for the core team)?
It's not really good for SEO as it is now.