Internal Server Error

Permalink Browser Info Environment
Smooth scrolling doesn't work for me. Links to anchors are just jumping instead of smoothly scrolling. While smoothTag.js is loaded correctly, Firebug reports an error:

"NetworkError: 500 Internal Server Error -https://.../index.php/package/smoothtag/controller/config"...

Any idea, what could be causing this?

Btw, on your demo page, smooth scrolling doesn't work for smaller screens. Anchor links are just jumping. Trying the demo on a smartphone or even resizing the width of the destop screen also shows that behavior. Is that intentionally?

Thank you,
Michael

Type: Pre-Sale
Status: Resolved
okapi
View Replies:
ob7dev replied on at Permalink Reply
ob7dev
It can work on mobile... I think it might be turned off though. I will look into that.
I will also find out why its giving you an error.
I will be back shortly.
ob7dev replied on at Permalink Reply
ob7dev
Line 51 of smoothTag.js sets the min-width for enabling the effect to 960px.

As for the server error... I'm unable to reproduce...
PHP 5 or 7?
okapi replied on at Permalink Reply
okapi
Thanks for the information! I will try this out, as soon as i manage to get it to work.
Yes, PHP 7 here, maybe that's causing the problem...
ob7dev replied on at Permalink Reply
ob7dev
Are you using default settings? If not can you post what you have put in on the dashboard settings for the plugin?

I will check 7.
okapi replied on at Permalink Reply
okapi
Yes, i'm using the default settings.
ob7dev replied on at Permalink Reply
ob7dev
PHP 7 is throwing errors.

Guess I need to fix that.
okapi replied on at Permalink Reply
okapi
Yes... maybe this helps (you might have examined that already):

{"error":{"message":"Declaration of Concrete\\Package\\SmoothTag\\Controller\\Config::get() should be
 compatible with Concrete\\Core\\Controller\\AbstractController::get($key = NULL, $defaultValue = NULL
)"},"errors":["Declaration of Concrete\\Package\\SmoothTag\\Controller\\Config::get() should be compatible
 with Concrete\\Core\\Controller\\AbstractController::get($key = NULL, $defaultValue = NULL)"]}

Maybe a namespacing issue?
ob7dev replied on at Permalink Reply
ob7dev
Its because I called the function "get" and I guess that doesn't work in PHP7.

So I renamed the function to loadSavedConfig and everything seems to be working again.

I just uploaded version 1.1 with those changes made.

If you want to update your own copy without reinstalling, just update line 52 of smooth_tag/controller.php from config::get to config::loadSavedConfig and everything should work.
ob7dev replied on at Permalink Reply
ob7dev
Oh sorry, you also need to update it inside smooth_tag/controllers/config.php if your patching it manually.
okapi replied on at Permalink Reply
okapi
Wow... you made my day! Thank you so much for your help!!
It works great now even on smartphone, since i changed the value on line 51 of smoothTag.js!
Thanks again,
Michael
ob7dev replied on at Permalink Reply
ob7dev
Anytime :) Thanks for helping me get it working in php7.

concrete5 Environment Information

Concrete5 8.1

Browser User-Agent String

Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0

Hide Post Content

This will replace the post content with the message: "Content has been removed by an Administrator"

Hide Content

Request Refund

You have not specified a license for this support ticket. You must have a valid license assigned to a support ticket to request a refund.