Style not correctly handled

Permalink Browser Info Environment
In the dashboard page (/dashboard/files/whale_elastic_slider/edit/...), I set the Style field (the one marked with "Styles should have selectors and injected into page. So be aware not to insert loose styles that may affect other elements of page").

The block controller, however, does not include the above style in the page.
Here's the (wrong) code in blocks/whale_elastic_slider/controller.php:
//style
if(isset($this->slider->optionsObj->style) && strlen($this->slider->optionsObj->style)>0){
    $css.= sprintf('%s' ,$this->slider->containerID ,$this->slider->optionsObj->style );
}


As you can see, the value of $this->slider->optionsObj->style is not included in $css.
I fixed the problem by replacing the above code with this:
//style
if(isset($this->slider->optionsObj->style) && strlen($this->slider->optionsObj->style)>0){
    $css.= $this->slider->optionsObj->style;
}

Type: Discussion
Status: In Progress
View Replies:
shahroq replied on at Permalink Reply
shahroq
Hi,
Thanx for the hint, i just updated the add-on with number of other fixes.
Cheers,

concrete5 Environment Information

n/a

Browser User-Agent String

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.84 Safari/537.36

Hide Post Content

This will replace the post content with the message: "Content has been removed by an Administrator"

Hide Content

Request Refund

You may not request a refund that is not currently owned by you.