Monitor Reply

Support

Hidden required fields

Permalink Browser Info Environment September 18, 2017 at 2:17 PM

Hey there,

currentlty we have a problem with the Advanced Forms plugin for Concrete5. We created a Form with different visibility rules to show and hide different input fieds, some of them are required.

If the form is to be sent, we receive a error message that the hidden input fields are missing.

Is there a possibility to ignore/override hidden required fields?

Type:	Ticket
Status:	Archived

aenowwebsite replied on Sep 12, 2018 at 4:30 pm Permalink Reply

Based of version 3.0:
In /packages/formify/src/FormifyField.php replace the validate function

public function validate($data, $answers=null) {
      $errors = array();
        $passesRules = true;
      if ($this->enableRules) {
            $matchedCount = 0;
            foreach ($this->getRules() as $rule) {
                if ($rule['comparison'] == '=') {
                    $matchedCount = $matchedCount + (($rule['value'] == $answers[$rule['comparisonFieldID']]) ? 1 : 0);
                } else if ($rule['comparison'] == '!=') {
                    $matchedCount = $matchedCount + (($rule['value'] != $answers[$rule['comparisonFieldID']]) ? 1 : 0);
                //Contains
                }else if ($rule['comparison'] == '~') {
                    $matchedCount = $matchedCount + ((strpos($answers[$rule['comparisonFieldID']], $rule['value']) !== false) ? 1 : 0);
                //does not contain
                }else if ($rule['comparison'] == '!~') {

Viewing 15 lines of 83 lines. View entire code block.

 
public function validate($data, $answers=null) {
 
      $errors = array();
 
        $passesRules = true;
      if ($this->enableRules) {
            $matchedCount = 0;
            foreach ($this->getRules() as $rule) {
 
                if ($rule['comparison'] == '=') {
                    $matchedCount = $matchedCount + (($rule['value'] == $answers[$rule['comparisonFieldID']]) ? 1 : 0);
                } else if ($rule['comparison'] == '!=') {
                    $matchedCount = $matchedCount + (($rule['value'] != $answers[$rule['comparisonFieldID']]) ? 1 : 0);
                //Contains
                }else if ($rule['comparison'] == '~') {
 
                    $matchedCount = $matchedCount + ((strpos($answers[$rule['comparisonFieldID']], $rule['value']) !== false) ? 1 : 0);
                //does not contain
                }else if ($rule['comparison'] == '!~') {
 
 
                    $matchedCount = $matchedCount + (!((strpos($answers[$rule['comparisonFieldID']], $rule['value']) !== false)) ? 1 : 0);
                }
            }
 
 
            if ($this->ruleRequirement == 'all') {
 
 
                if (!($matchedCount == count($this->getRules()))) {
                    $passesRules = false;
                }
            } else {
                if (count($this->getRules()) !== 0 && $matchedCount  === 0) {
                    $passesRules = false;
                }
            }
        }
 
        if ($passesRules === false) {
 
            return true;
        }
      /* Required fields */
      if(($this->isRequired) && ($this->getType()->hasInput())) { //Determine if it's required
          if(is_array($data)) {
              if(count($data) > 0) {
                  foreach($data as $value) {
                      if($value == '') {
                          return false;
                      }
                  }
              }
          } else {
             if($data == '') { //See if the actual value is blank
                return false;
             }
         }
      }
 
      /* Regular expression validation */
      if($this->regex != '') {
         if($data != '') {
            if((preg_match($this->regex,$data) == 0) && ($data != '')) {
               return false;
            }
         }
      }
 
      /* Email validation */
      if($this->type == 'email') {
         if((!preg_match("/^[[:alnum:]][a-z0-9_.-]*@[a-z0-9.-]+\.[a-z]{2,8}$/i", $data)) && ($data != '')) {
            return false;
         }
      }
 
      if($this->type == 'date') {
          if(is_array($data)) { // Date value is in array parts
              $dateString = $data[0] . '-' . $data[1] . '-' . $data[2];
            $dt = \DateTime::createFromFormat('n-j-Y',$dateString);
         } else { // Date value is string
            if($field->dateFormat != '') {
                $df = $this->dateFormat;
            } else {
                $df = 'F j, Y';
            }
            $dateString = $data;
            $dt = \DateTime::createFromFormat($this->dateFormat,$dateString);
         }
 
         $dateErrors = \DateTime::getLastErrors();
         if(($dateErrors['warning_count'] > 0) || ($dateErrors['error_count'] > 0)) {
             if(($dateString != '--') && ($dateString != '')) {
                 return false;
                }
         }
      }
 
      return true;
 
   }

On line 217 of /packages/formify/controllers/api/records.php replace

if(!$ff->validate($answers[$ff->ffID])) {

with

if(!$ff->validate($answers[$ff->ffID], $answers)) {

You will also need to make modifications to view.js in the block to ensure it doesn't submit hidden field data which it currently does.

ConcreteCMS replied on Sep 27, 2018 at 1:08 am Permalink Reply