Suggestion for jQuery- use outerHeight

Permalink Browser Info Environment
Hi,

All in all a great plugin- just leaving a small suggestion for the package's javascript. I would change lines 47 through 49 to the following as images with borders, (or background images + padding to make borders) are clipped by the current code.

if (imgHeight == null) {imgHeight = $(".formigo-slider-item-image-left-image > img").outerHeight()};
if (imgHeight == null) {imgHeight = $(".formigo-slider-item-image-right-image > img").outerHeight()};
if (imgHeight == null) {imgHeight = $(".formigo-slider-item-full-image > img").outerHeight()};

Type: Discussion
Status: New
dosomethingdifferent
View Replies:
formigo replied on at Permalink Reply
formigo
Hi thanks for this. Great suggestion. When we next revisit the add-on we'll be sure to factor this in.

Best

Ollie

concrete5 Environment Information

Browser User-Agent String

Hide Post Content

This will replace the post content with the message: "Content has been removed by an Administrator"

Hide Content

Request Refund

You have not specified a license for this support ticket. You must have a valid license assigned to a support ticket to request a refund.