Tested Image Optomizer in concrete5 8.5.0RC1

Permalink Browser Info Environment
Just for info...

Just tested Image Optimizer in concrete5 8.5.0RC1 and while running the job I got the following error:

Unresolvable dependency resolving [Parameter #0 [ $name ]] in class Monolog\Logger

I expect you already know this, so consider this as friendly reminder.

/Michael

Type: Discussion
Status: In Progress
maar
View Replies:
A3020 replied on at Permalink Reply
A3020
Yes, I'm familiar with that bug. I've updated the GDPR pkg recently to fix it. It's a BC break introduced in 8.4.4+, I think. I'll take a look for Image Optimizer.
A3020 replied on at Permalink Reply
A3020
I submitted version 3.2.7 which should have the issue resolved. Thanks for reporting!
maar replied on at Permalink Reply
maar
Cool...
katalysis replied on at Permalink Reply
katalysis
Just downloaded the lates version and this issue still seems to be present on 8.5.1:

Call to a member function useLogger() on null

Details

/var/www/vhosts/reespage.com/httpdocs/packages/image_optimizer/src/ImageOptimizer/Queue/Process.php(58): Error->null
/var/www/vhosts/reespage.com/httpdocs/packages/image_optimizer/jobs/image_optimizer.php(105): A3020\ImageOptimizer\Queue\Process->process
/var/www/vhosts/reespage.com/httpdocs/concrete/src/Job/QueueableJob.php(168): Concrete\Package\ImageOptimizer\Job\ImageOptimizer->processQueueItem
/var/www/vhosts/reespage.com/httpdocs/concrete/controllers/frontend/jobs.php(116): Concrete\Core\Job\QueueableJob->executeBatch
/var/www/vhosts/reespage.com/httpdocs/concrete/src/Controller/AbstractController.php(294): Concrete\Controller\Frontend\Jobs->run_single
/var/www/vhosts/reespage.com/httpdocs/concrete/src/Controller/AbstractController.php(294): null->call_user_func_array
/var/www/vhosts/reespage.com/httpdocs/concrete/src/Routing/ControllerRouteAction.php(61): Concrete\Core\Controller\AbstractController->runAction
/var/www/vhosts/reespage.com/httpdocs/concrete/src/Http/RouteDispatcher.php(37): Concrete\Core\Routing\ControllerRouteAction->execute
/var/www/vhosts/reespage.com/httpdocs/concrete/src/Http/Middleware/DispatcherDelegate.php(39): Concrete\Core\Http\RouteDispatcher->dispatch
/var/www/vhosts/reespage.com/httpdocs/concrete/src/Http/Middleware/MiddlewareStack.php(86): Concrete\Core\Http\Middleware\DispatcherDelegate->next
/var/www/vhosts/reespage.com/httpdocs/concrete/src/Http/DefaultDispatcher.php(126): Concrete\Core\Http\Middleware\MiddlewareStack->process
/var/www/vhosts/reespage.com/httpdocs/concrete/src/Http/DefaultDispatcher.php(58): Concrete\Core\Http\DefaultDispatcher->handleDispatch
/var/www/vhosts/reespage.com/httpdocs/concrete/src/Http/Middleware/DispatcherDelegate.php(39): Concrete\Core\Http\DefaultDispatcher->dispatch
/var/www/vhosts/reespage.com/httpdocs/concrete/src/Http/Middleware/ThumbnailMiddleware.php(76): Concrete\Core\Http\Middleware\DispatcherDelegate->next
/var/www/vhosts/reespage.com/httpdocs/concrete/src/Http/Middleware/MiddlewareDelegate.php(50): Concrete\Core\Http\Middleware\ThumbnailMiddleware->process
/var/www/vhosts/reespage.com/httpdocs/concrete/src/Http/Middleware/FrameOptionsMiddleware.php(39): Concrete\Core\Http\Middleware\MiddlewareDelegate->next
/var/www/vhosts/reespage.com/httpdocs/concrete/src/Http/Middleware/MiddlewareDelegate.php(50): Concrete\Core\Http\Middleware\FrameOptionsMiddleware->process
/var/www/vhosts/reespage.com/httpdocs/concrete/src/Http/Middleware/CookieMiddleware.php(35): Concrete\Core\Http\Middleware\MiddlewareDelegate->next
/var/www/vhosts/reespage.com/httpdocs/concrete/src/Http/Middleware/MiddlewareDelegate.php(50): Concrete\Core\Http\Middleware\CookieMiddleware->process
/var/www/vhosts/reespage.com/httpdocs/concrete/src/Http/Middleware/ApplicationMiddleware.php(29): Concrete\Core\Http\Middleware\MiddlewareDelegate->next
/var/www/vhosts/reespage.com/httpdocs/concrete/src/Http/Middleware/MiddlewareDelegate.php(50): Concrete\Core\Http\Middleware\ApplicationMiddleware->process
/var/www/vhosts/reespage.com/httpdocs/concrete/src/Http/Middleware/MiddlewareStack.php(86): Concrete\Core\Http\Middleware\MiddlewareDelegate->next
/var/www/vhosts/reespage.com/httpdocs/concrete/src/Http/DefaultServer.php(85): Concrete\Core\Http\Middleware\MiddlewareStack->process
/var/www/vhosts/reespage.com/httpdocs/concrete/src/Foundation/Runtime/Run/DefaultRunner.php(119): Concrete\Core\Http\DefaultServer->handleRequest
/var/www/vhosts/reespage.com/httpdocs/concrete/src/Foundation/Runtime/DefaultRuntime.php(102): Concrete\Core\Foundation\Runtime\Run\DefaultRunner->run
/var/www/vhosts/reespage.com/httpdocs/concrete/dispatcher.php(36): Concrete\Core\Foundation\Runtime\DefaultRuntime->run
/var/www/vhosts/reespage.com/httpdocs/index.php(2): null->require
A3020 replied on at Permalink Reply
A3020
@katalysis that's another bug. Please check the QueueMessages database table and remove all records that derive from Image Optimizer. This is safe to do. Then start the job again (preferably via CLI).

The reason for this bug is:
- In earlier versions a different reference to a file was used (e.g. fID instead of fileId).
- Apparently not all images were optimized before you upgraded the add-on.

In the meantime I'll see if I can release an update to get around this problem as well.
katalysis replied on at Permalink Reply
katalysis
QueueMessages table is actually empty.
A3020 replied on at Permalink Reply
A3020
This error is only triggered when processing the queue, so... that's odd.
/var/www/vhosts/reespage.com/httpdocs/packages/image_optimizer/src/ImageOptimizer/Queue/Process.php(58): Error->null

I've uploaded version 3.2.9. I hope that fixes the issue for you!

concrete5 Environment Information

None

Browser User-Agent String

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Hide Post Content

This will replace the post content with the message: "Content has been removed by an Administrator"

Hide Content

Request Refund

You may not request a refund that is not currently owned by you.