Approving edits
Permalink Browser Info Environment
Great idea, clients will love that feature!
Just one question: to approve the edits, the client still has to have access to "edit page". He may ask himself why he should actually edit the page "inline" and then go back to the standard "edit page" to approve the edits he made? Wouldn't it be helpful, if at least that link "This page is pending approval - Approve Version" would not fade away after two seconds but keep staying there until the link "Approve Version" is clicked?
Just one question: to approve the edits, the client still has to have access to "edit page". He may ask himself why he should actually edit the page "inline" and then go back to the standard "edit page" to approve the edits he made? Wouldn't it be helpful, if at least that link "This page is pending approval - Approve Version" would not fade away after two seconds but keep staying there until the link "Approve Version" is clicked?
| Type: | Discussion |
|---|---|
| Status: | New |
Thanks for the quick response and sorry for my english. Yes, i think the box disappears too quickly. Maybe 10 seconds would be fine, but actually, why does that box have to disappear at all? For me, an unapproved page should be marked permanently as unapproved - until approval. Could you please give me a hint where that timeout can be set?
Michael
Michael
I hate to say this, because it's a poor excuse, but the reason why I want the box to disappear is because that's how the c5 core does it, and I want to try to fit seamlessly into C5 as much as possible.
With that being said:
1. I think you're right, and I would fully support this change to the core. In fact, I'm trying to figure out how to file a feature request. But in the meantime, I changed to 25 seconds.
2. To change the behavior in my add-on, you'd edit line 82 of simplecontent.js and remove the number (so .hud(msg); ). To change the core's behavior, it'd be line 158 in concrete/tools/page_controls_menu_js.php. But in both circumstances, be aware that any upgrades would reset your changes.
If there is enough demand and the request to change the core isn't accepted, I'd be open to adding a config setting somewhere, but I'd like to keep configuration as simple as possible (I'm of the Apple mindset).
James
With that being said:
1. I think you're right, and I would fully support this change to the core. In fact, I'm trying to figure out how to file a feature request. But in the meantime, I changed to 25 seconds.
2. To change the behavior in my add-on, you'd edit line 82 of simplecontent.js and remove the number (so .hud(msg); ). To change the core's behavior, it'd be line 158 in concrete/tools/page_controls_menu_js.php. But in both circumstances, be aware that any upgrades would reset your changes.
If there is enough demand and the request to change the core isn't accepted, I'd be open to adding a config setting somewhere, but I'd like to keep configuration as simple as possible (I'm of the Apple mindset).
James
Hi James
I have to agree that the timeout is not long enough and should possibly stay permanent until approved. Currently this may cause confusion for the users.
Cheers
Rob
I have to agree that the timeout is not long enough and should possibly stay permanent until approved. Currently this may cause confusion for the users.
Cheers
Rob
Hi.
I'd just like to clarify. The original message was in reference to a 5 second timeout. Since version 1, there has been a 25 second timeout.
Do you have version 1? Are ou saying that 25 seconds isn't long enough?
James
I'd just like to clarify. The original message was in reference to a 5 second timeout. Since version 1, there has been a 25 second timeout.
Do you have version 1? Are ou saying that 25 seconds isn't long enough?
James
Hi James
I am using version concrete5.4.1.1 and the messages for both the creator and approver stays up for about 5 seconds.
Rob
I am using version concrete5.4.1.1 and the messages for both the creator and approver stays up for about 5 seconds.
Rob
@silko,
jshannon means the version of the add-on, not the version of concrete5...!
As of the latest version of the add-on the timeout for approval notification is 25 seconds.
Michael
jshannon means the version of the add-on, not the version of concrete5...!
As of the latest version of the add-on the timeout for approval notification is 25 seconds.
Michael
You guys might be interested in the discussion here:http://www.concrete5.org/community/forums/customizing_c5/make-and03...
(copy page_controls_menu.php from concrete/tools/ to /tools/ then edit line 188:
The number there (default 5000) is the number of milliseconds the notification appears for. I use 120000 (i.e. 2 minutes).
(copy page_controls_menu.php from concrete/tools/ to /tools/ then edit line 188:
$(function() { ccmAlert.hud('<?php echo str_replace("'",'"',$statusMessage) ?>', 120000); });The number there (default 5000) is the number of milliseconds the notification appears for. I use 120000 (i.e. 2 minutes).
Five seconds is the time that the c5 core shows the dialog box for, so that's what I set, without really thinking if it's a reasonable amount of time under these circumstances. But I think you're right... I'll make it longer. (The dialog box doesn't have a "close" button to it, so I think it should have a timeout.)
BTW: You can also get the dialog box to show up again if you reload the page (normal c5 functionality), which is what I subconsciously do and the reason why the 5 second timeout hasn't bothered me.
James