topic tree translation not displayed

Permalink Browser Info Environment
Hi Dave,

I'm using the page list to filter the pages by topic attribute. I have a multilanguage site and al topics are translated in 2 languages.

The list filters excellent on the topics, but the topics only display in the first made language. Now my english pages have dutch topic lists. This is not very handy :-)

Could you please look into this, so the translations are respected by the list? The translations do work for the core list.

Kind regards,
Maura

Type: Ticket
Status: Archived
buurvrouw
View Replies:
SkyBlueSofa replied on at Permalink Reply
SkyBlueSofa
I'm a bit confused when you say that the 'topics only display in the first made language'. Where is this happening? In the Edit Page List+ form or somewhere else?
buurvrouw replied on at Permalink Reply 1 Attachment
buurvrouw
I'm using topics in a multilanguage site. In dashboard/international/translate site interface i've translated the topic-names from dutch to english.

In the page-list i'm using a search filter for topics. But in the list the translation is not displayed. I'm getting the dutch topic names in my search-selection instead of the english names.

See the screenshot for the english page, as you can see the topics still display in dutch.
SkyBlueSofa replied on at Permalink Reply
SkyBlueSofa
From my review of the code, it looks like this is a core issue.

Can you replace the getTreeNodeDisplayPath() in /concrete/src/Tree/Node/Node.php on line 207 with this code:
public function getTreeNodeDisplayPath()
    {
        $path = '/';
        $nodes = array_reverse($this->getTreeNodeParentArray());
        for ($i = 0; $i < count($nodes); $i++) {
            if ($i == 0) {
                continue;
            }
            $n = $nodes[$i];
            $path .= $n->getTreeNodeDisplayName('text') . '/';
        }
        if (count($nodes) > 0) {
            $path .= $this->getTreeNodeDisplayName('text');
        }
        return $path;

Note the changes on line 216 and 219 from "getTreeNodeName()" to "getTreeNodeDisplayName('text')".

If this works, I will submit the change to c5 for integration into the next version.
buurvrouw replied on at Permalink Reply
buurvrouw
Hi Dave,

This does work for the translations. But the filtering doesn't work in the second language page.

I think something very weird is happening...

1. Dutch page, with list and filters, working perfectly
2. Copy this dutch page to english tree
3. Set filter to list from everywhere (so including dutch and english pages)
4. Using no custom templates for the list, just default listing
5. The list is displayed as it should

So far, so good.
Now, when i select a filter it comes up with no result at all.

I don't think this is a result of the code change, because the list didn't work before this. I thought this was because the filters were not translated. But i guess something else is wrong.

Do you have any idea? I could give you access to the site if that woud be helpful?

Later today i will do a test on a clean site, to see if that still gives an empty list.
SkyBlueSofa replied on at Permalink Reply
SkyBlueSofa
It's probably a combination of things.

Can you turn on debugging in the 'display' tab of the Page List+ form. The last query that is shown is the one that gets run to gather the pages that are displayed in the list. Does it seem right? Can you post it here or PM it to me?

Perhaps access to the site would work. However, to make changes, I would need FTP access to the server.
buurvrouw replied on at Permalink Reply
buurvrouw
Hi Dave,

This issue has been a while ago. The site i was working on was postponed, but is now live and soon the translations have to go live too.

But the issue above still exists. The translations of the topics work with your suggested changes in the core code, but the filtering doesn't work. Could you help me to get this sorted out?
SkyBlueSofa replied on at Permalink Reply
SkyBlueSofa
Just to confirm:
1. Filtering works for the main language
2. Filtering does not work for additional languages

Is this correct?
buurvrouw replied on at Permalink Reply
buurvrouw
Yes, that's correct.
buurvrouw replied on at Permalink Reply
buurvrouw
I bumped into another issue related to the additional languages:

When using a pagelistplus, with filter functionality (no search functionality active):
check a custom attribute and select 'matches any from current page'

I do get the filtered list when saving the list, but as soon as publishing the page, the list is blanc.
When going in edit mode again the list is still blanc. Then edit the list (change nothing) and sav it again, the list displays. But again when publishing the list is blanc again...

I hope you can look into this too?
buurvrouw replied on at Permalink Reply
buurvrouw
Hi Dave,

Did you find some time to look into this issue yet? I know it's vacation time, but it would be awesome if i can use the list for additional languages any time soon.

If i need to pay for some support time, that would be fine for me. Let me know.

regards, Maura
ConcreteCMS replied on at Permalink Reply
ConcreteCMS
Attention: Since there has been no activity on this issue for two weeks, this issue has been automatically archived.

To re-open this issue, reply to this message.
ConcreteCMS replied on at Permalink Reply
ConcreteCMS
Attention: Since there has been no activity on this issue for two weeks, this issue has been automatically archived.

To re-open this issue, reply to this message.
haeflimi replied on at Permalink Reply
haeflimi
In case somebody still cares about this.:
The reason for this is a translation bug in the core that affects the topic attribute.
We are maintaining a Package/ Block similar in functionality to PageList+ and ran into the same issue.

I have opened a core Issue here:
https://github.com/concrete5/concrete5/issues/7731...

Feel free to comment and bump it there. I hope to find the time to look into it and create a PR sometime soon.
1stthomas replied on at Permalink Reply
1stthomas
I've updated the github issue with a suggestion of a possible fix of this problem.
ConcreteCMS replied on at Permalink Reply
ConcreteCMS
Attention: Since there has been no activity on this issue for two weeks, this issue has been automatically archived.

To re-open this issue, reply to this message.
ConcreteCMS replied on at Permalink Reply
ConcreteCMS
Attention: Since there has been no activity on this issue for two weeks, this issue has been automatically archived.

To re-open this issue, reply to this message.
ConcreteCMS replied on at Permalink Reply
ConcreteCMS
Attention: Since there has been no activity on this issue for two weeks, this issue has been automatically archived.

To re-open this issue, reply to this message.
ConcreteCMS replied on at Permalink Reply
ConcreteCMS
Attention: Since there has been no activity on this issue for two weeks, this issue has been automatically archived.

To re-open this issue, reply to this message.

concrete5 Environment Information

# concrete5 Version
Core Version - 5.7.5.3
Version Installed - 5.7.5.3
Database Version - 20150731000000

# concrete5 Packages
Block Designer (1.3.3), Honest Websites Back To Top (0.9.4), Page List+ (1.2.9), ProEvents (2.7.2), Search Experience Optimization (1.2.1), Simple Slider (1.0), Studio Testimonials Pro (1.0.2), Supermint Theme (3.3.1.2).

# concrete5 Overrides
blocks/page_list_plus/templates/thumbnail_grid/view.php, blocks/page_list_plus/templates/thumbnail_grid/view.css, blocks/page_list_plus/templates/thumbnail_grid, blocks/page_list_plus/templates/test/view.php, blocks/page_list_plus/templates/test, blocks/page_list_plus/templates/agenda/view.php, blocks/page_list_plus/templates/agenda, blocks/page_list_plus/templates/aanbod 4koloms/view.php, blocks/page_list_plus/templates/aanbod 4koloms, blocks/page_list_plus/templates/boerma/view.php, blocks/page_list_plus/templates/boerma, blocks/page_list_plus/templates, blocks/page_list_plus, blocks/content/templates/event_post/view.php, blocks/content/templates/event_post/view.css, blocks/content/templates/event_post, blocks/content/templates, blocks/content, blocks/shop_product/form.php, blocks/shop_product/icon.png, blocks/shop_product/controller.php, blocks/shop_product/view.php, blocks/shop_product/add.php, blocks/shop_product/composer.php, blocks/shop_product/config.json, blocks/shop_product/db.xml, blocks/shop_product/edit.php, blocks/shop_product, blocks/page_attribute_display/templates/date_time.php, blocks/page_attribute_display/templates/boolean.php, blocks/page_attribute_display/templates, blocks/page_attribute_display, blocks/switch_language/templates/text/view.php, blocks/switch_language/templates/text/view.css, blocks/switch_language/templates/text, blocks/switch_language/templates, blocks/switch_language, blocks/pro_event_list/templates/boerma/view.php, blocks/pro_event_list/templates/boerma/view.css, blocks/pro_event_list/templates/boerma, blocks/pro_event_list/templates, blocks/pro_event_list, blocks/studio_testimonials_pro/templates/boerma_quotes/view.php, blocks/studio_testimonials_pro/templates/boerma_quotes, blocks/studio_testimonials_pro/templates/boerma_list/view.php, blocks/studio_testimonials_pro/templates/boerma_list, blocks/studio_testimonials_pro/templates, blocks/studio_testimonials_pro, languages/en_GB/LC_MESSAGES/messages.mo, languages/en_GB/LC_MESSAGES, languages/en_GB, languages/site/nl_NL.mo, languages/site/en_GB.po, languages/site/en_GB.mo, languages/site/nl_NL.po, languages/site, languages/nl_NL/LC_MESSAGES/messages.mo, languages/nl_NL/LC_MESSAGES, languages/nl_NL, themes/supermint/left_sidebar.php, themes/supermint/images/beeldmerk-groen-20pct.jpg, themes/supermint/images/patterns/noise.png, themes/supermint/images/patterns, themes/supermint/images, themes/supermint/left_sidebar_event.php, themes/supermint/right_sidebar.php, themes/supermint/css/boerma.css, themes/supermint/css, themes/supermint/elements/head.php, themes/supermint/elements, themes/supermint, blocks/page_list_plus/templates/thumbnail_grid/view.php, blocks/page_list_plus/templates/thumbnail_grid/view.css, blocks/page_list_plus/templates/thumbnail_grid, blocks/page_list_plus/templates/test/view.php, blocks/page_list_plus/templates/test, blocks/page_list_plus/templates/agenda/view.php, blocks/page_list_plus/templates/agenda, blocks/page_list_plus/templates/aanbod 4koloms/view.php, blocks/page_list_plus/templates/aanbod 4koloms, blocks/page_list_plus/templates/boerma/view.php, blocks/page_list_plus/templates/boerma, blocks/page_list_plus/templates, blocks/page_list_plus, blocks/content/templates/event_post/view.php, blocks/content/templates/event_post/view.css, blocks/content/templates/event_post, blocks/content/templates, blocks/content, blocks/shop_product/form.php, blocks/shop_product/icon.png, blocks/shop_product/controller.php, blocks/shop_product/view.php, blocks/shop_product/add.php, blocks/shop_product/composer.php, blocks/shop_product/config.json, blocks/shop_product/db.xml, blocks/shop_product/edit.php, blocks/shop_product, blocks/page_attribute_display/templates/date_time.php, blocks/page_attribute_display/templates/boolean.php, blocks/page_attribute_display/templates, blocks/page_attribute_display, blocks/switch_language/templates/text/view.php, blocks/switch_language/templates/text/view.css, blocks/switch_language/templates/text, blocks/switch_language/templates, blocks/switch_language, blocks/pro_event_list/templates/boerma/view.php, blocks/pro_event_list/templates/boerma/view.css, blocks/pro_event_list/templates/boerma, blocks/pro_event_list/templates, blocks/pro_event_list, blocks/studio_testimonials_pro/templates/boerma_quotes/view.php, blocks/studio_testimonials_pro/templates/boerma_quotes, blocks/studio_testimonials_pro/templates/boerma_list/view.php, blocks/studio_testimonials_pro/templates/boerma_list, blocks/studio_testimonials_pro/templates, blocks/studio_testimonials_pro, languages/en_GB/LC_MESSAGES/messages.mo, languages/en_GB/LC_MESSAGES, languages/en_GB, languages/site/nl_NL.mo, languages/site/en_GB.po, languages/site/en_GB.mo, languages/site/nl_NL.po, languages/site, languages/nl_NL/LC_MESSAGES/messages.mo, languages/nl_NL/LC_MESSAGES, languages/nl_NL, themes/supermint/left_sidebar.php, themes/supermint/images/beeldmerk-groen-20pct.jpg, themes/supermint/images/patterns/noise.png, themes/supermint/images/patterns, themes/supermint/images, themes/supermint/left_sidebar_event.php, themes/supermint/right_sidebar.php, themes/supermint/css/boerma.css, themes/supermint/css, themes/supermint/elements/head.php, themes/supermint/elements, themes/supermint

# concrete5 Cache Settings
Block Cache - On
Overrides Cache - On
Full Page Caching - On - If blocks on the particular page allow it.
Full Page Cache Lifetime - Every 6 hours (default setting).

# Server Software
Apache/2

# Server API
cgi-fcgi

# PHP Version
5.6.7

# PHP Extensions
bcmath, calendar, cgi-fcgi, Core, ctype, curl, date, dom, ereg, exif, fileinfo, filter, ftp, gd, gettext, hash, iconv, imap, intl, ionCube Loader, json, ldap, libxml, mbstring, mcrypt, mhash, mssql, mysql, mysqli, mysqlnd, openssl, pcre, PDO, pdo_mysql, pdo_sqlite, Phar, posix, Reflection, session, SimpleXML, soap, sockets, SPL, sqlite3, standard, tokenizer, wddx, xml, xmlreader, xmlwriter, xsl, zip, zlib.

# PHP Settings
max_execution_time - 30
log_errors_max_len - 1024
max_file_uploads - 20
max_input_nesting_level - 64
max_input_time - 60
max_input_vars - 1000
memory_limit - 128M
post_max_size - 64M
sql.safe_mode - Off
upload_max_filesize - 64M
ldap.max_links - Unlimited
mssql.max_links - Unlimited
mssql.max_persistent - Unlimited
mssql.max_procs - Unlimited
mssql.textlimit - Server default
mysql.max_links - Unlimited
mysql.max_persistent - Unlimited
mysqli.max_links - Unlimited
mysqli.max_persistent - Unlimited
pcre.backtrack_limit - 1000000
pcre.recursion_limit - 100000
session.cache_limiter - <i>no value</i>
session.gc_maxlifetime - 1440
soap.wsdl_cache_limit - 5

Browser User-Agent String

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_2) AppleWebKit/601.3.9 (KHTML, like Gecko) Version/9.0.2 Safari/601.3.9

Hide Post Content

This will replace the post content with the message: "Content has been removed by an Administrator"

Hide Content

Request Refund

You may not request a refund that is not currently owned by you.