topic tree translation not displayed
Permalink Browser Info Environment
Hi Dave,
I'm using the page list to filter the pages by topic attribute. I have a multilanguage site and al topics are translated in 2 languages.
The list filters excellent on the topics, but the topics only display in the first made language. Now my english pages have dutch topic lists. This is not very handy :-)
Could you please look into this, so the translations are respected by the list? The translations do work for the core list.
Kind regards,
Maura
I'm using the page list to filter the pages by topic attribute. I have a multilanguage site and al topics are translated in 2 languages.
The list filters excellent on the topics, but the topics only display in the first made language. Now my english pages have dutch topic lists. This is not very handy :-)
Could you please look into this, so the translations are respected by the list? The translations do work for the core list.
Kind regards,
Maura
Type: | Ticket |
---|---|
Status: | Archived |
I'm a bit confused when you say that the 'topics only display in the first made language'. Where is this happening? In the Edit Page List+ form or somewhere else?
I'm using topics in a multilanguage site. In dashboard/international/translate site interface i've translated the topic-names from dutch to english.
In the page-list i'm using a search filter for topics. But in the list the translation is not displayed. I'm getting the dutch topic names in my search-selection instead of the english names.
See the screenshot for the english page, as you can see the topics still display in dutch.
In the page-list i'm using a search filter for topics. But in the list the translation is not displayed. I'm getting the dutch topic names in my search-selection instead of the english names.
See the screenshot for the english page, as you can see the topics still display in dutch.
From my review of the code, it looks like this is a core issue.
Can you replace the getTreeNodeDisplayPath() in /concrete/src/Tree/Node/Node.php on line 207 with this code:
Note the changes on line 216 and 219 from "getTreeNodeName()" to "getTreeNodeDisplayName('text')".
If this works, I will submit the change to c5 for integration into the next version.
Can you replace the getTreeNodeDisplayPath() in /concrete/src/Tree/Node/Node.php on line 207 with this code:
public function getTreeNodeDisplayPath() { $path = '/'; $nodes = array_reverse($this->getTreeNodeParentArray()); for ($i = 0; $i < count($nodes); $i++) { if ($i == 0) { continue; } $n = $nodes[$i]; $path .= $n->getTreeNodeDisplayName('text') . '/'; } if (count($nodes) > 0) { $path .= $this->getTreeNodeDisplayName('text'); } return $path;
Viewing 15 lines of 16 lines. View entire code block.
Note the changes on line 216 and 219 from "getTreeNodeName()" to "getTreeNodeDisplayName('text')".
If this works, I will submit the change to c5 for integration into the next version.
Hi Dave,
This does work for the translations. But the filtering doesn't work in the second language page.
I think something very weird is happening...
1. Dutch page, with list and filters, working perfectly
2. Copy this dutch page to english tree
3. Set filter to list from everywhere (so including dutch and english pages)
4. Using no custom templates for the list, just default listing
5. The list is displayed as it should
So far, so good.
Now, when i select a filter it comes up with no result at all.
I don't think this is a result of the code change, because the list didn't work before this. I thought this was because the filters were not translated. But i guess something else is wrong.
Do you have any idea? I could give you access to the site if that woud be helpful?
Later today i will do a test on a clean site, to see if that still gives an empty list.
This does work for the translations. But the filtering doesn't work in the second language page.
I think something very weird is happening...
1. Dutch page, with list and filters, working perfectly
2. Copy this dutch page to english tree
3. Set filter to list from everywhere (so including dutch and english pages)
4. Using no custom templates for the list, just default listing
5. The list is displayed as it should
So far, so good.
Now, when i select a filter it comes up with no result at all.
I don't think this is a result of the code change, because the list didn't work before this. I thought this was because the filters were not translated. But i guess something else is wrong.
Do you have any idea? I could give you access to the site if that woud be helpful?
Later today i will do a test on a clean site, to see if that still gives an empty list.
It's probably a combination of things.
Can you turn on debugging in the 'display' tab of the Page List+ form. The last query that is shown is the one that gets run to gather the pages that are displayed in the list. Does it seem right? Can you post it here or PM it to me?
Perhaps access to the site would work. However, to make changes, I would need FTP access to the server.
Can you turn on debugging in the 'display' tab of the Page List+ form. The last query that is shown is the one that gets run to gather the pages that are displayed in the list. Does it seem right? Can you post it here or PM it to me?
Perhaps access to the site would work. However, to make changes, I would need FTP access to the server.
Hi Dave,
This issue has been a while ago. The site i was working on was postponed, but is now live and soon the translations have to go live too.
But the issue above still exists. The translations of the topics work with your suggested changes in the core code, but the filtering doesn't work. Could you help me to get this sorted out?
This issue has been a while ago. The site i was working on was postponed, but is now live and soon the translations have to go live too.
But the issue above still exists. The translations of the topics work with your suggested changes in the core code, but the filtering doesn't work. Could you help me to get this sorted out?
Just to confirm:
1. Filtering works for the main language
2. Filtering does not work for additional languages
Is this correct?
1. Filtering works for the main language
2. Filtering does not work for additional languages
Is this correct?
Yes, that's correct.
I bumped into another issue related to the additional languages:
When using a pagelistplus, with filter functionality (no search functionality active):
check a custom attribute and select 'matches any from current page'
I do get the filtered list when saving the list, but as soon as publishing the page, the list is blanc.
When going in edit mode again the list is still blanc. Then edit the list (change nothing) and sav it again, the list displays. But again when publishing the list is blanc again...
I hope you can look into this too?
When using a pagelistplus, with filter functionality (no search functionality active):
check a custom attribute and select 'matches any from current page'
I do get the filtered list when saving the list, but as soon as publishing the page, the list is blanc.
When going in edit mode again the list is still blanc. Then edit the list (change nothing) and sav it again, the list displays. But again when publishing the list is blanc again...
I hope you can look into this too?
Hi Dave,
Did you find some time to look into this issue yet? I know it's vacation time, but it would be awesome if i can use the list for additional languages any time soon.
If i need to pay for some support time, that would be fine for me. Let me know.
regards, Maura
Did you find some time to look into this issue yet? I know it's vacation time, but it would be awesome if i can use the list for additional languages any time soon.
If i need to pay for some support time, that would be fine for me. Let me know.
regards, Maura
Attention: Since there has been no activity on this issue for two weeks, this issue has been automatically archived.
To re-open this issue, reply to this message.
To re-open this issue, reply to this message.
Attention: Since there has been no activity on this issue for two weeks, this issue has been automatically archived.
To re-open this issue, reply to this message.
To re-open this issue, reply to this message.
In case somebody still cares about this.:
The reason for this is a translation bug in the core that affects the topic attribute.
We are maintaining a Package/ Block similar in functionality to PageList+ and ran into the same issue.
I have opened a core Issue here:
https://github.com/concrete5/concrete5/issues/7731...
Feel free to comment and bump it there. I hope to find the time to look into it and create a PR sometime soon.
The reason for this is a translation bug in the core that affects the topic attribute.
We are maintaining a Package/ Block similar in functionality to PageList+ and ran into the same issue.
I have opened a core Issue here:
https://github.com/concrete5/concrete5/issues/7731...
Feel free to comment and bump it there. I hope to find the time to look into it and create a PR sometime soon.
I've updated the github issue with a suggestion of a possible fix of this problem.
Attention: Since there has been no activity on this issue for two weeks, this issue has been automatically archived.
To re-open this issue, reply to this message.
To re-open this issue, reply to this message.
Attention: Since there has been no activity on this issue for two weeks, this issue has been automatically archived.
To re-open this issue, reply to this message.
To re-open this issue, reply to this message.
Attention: Since there has been no activity on this issue for two weeks, this issue has been automatically archived.
To re-open this issue, reply to this message.
To re-open this issue, reply to this message.
Attention: Since there has been no activity on this issue for two weeks, this issue has been automatically archived.
To re-open this issue, reply to this message.
To re-open this issue, reply to this message.