Causes invalid html

Permalink Browser Info Environment
This is a great addition :)
Thank you lots for it...

Just a couple of issues:

Validating the site with this installed gives a error due to the inline <style> tag added (needs to be in header).

Also missing the ALT tags for the images - can these be added please?

Also requires the markup to end with a /> not just > (self closing tags)

They should read <img src="imageSource" alt="alt text" /> for validation.

Type: Discussion
Status: New
SpudR
View Replies:
Vivid replied on at Permalink Reply
Vivid
Regarding the alt tags, an empty alt tag is just as invalid as no alt tag, and there's currently no functionality to edit text for the alt tag. So, I guess what I could do is put the powerphrase in the alt tag. Would that settle it for you?

Additionally, the inline CSS has to be.. there.. because it's written dynamically with certain settings as they're entered on the add/edit form. I believe C5 has a way to handle that, but I haven't looked into it. I may in the future.

The non-self-closing images will not change. Only in XHTML is it required. HTML4 and HTML5 doesn't do self closing tags, and I'd rather be future friendly with HTML5 than cater to XHTMLs demand for self-closed image tags. That being said, alt tags also aren't required in HTML5 (though it's still highly recommended), but that's something I'll probably add in regardless.
SpudR replied on at Permalink Reply
SpudR
Agreed on the future proofing - the endings should be as generic as possible.

I've amended the view.php file to add a generic alt tag and the ending /> and this now is working, but using the powerphrase would be great - that would give some level of control to allow these to be edited, but you'd need to add an option not to display them as overlays (I use this to show a series of images for client testimonials and there is no need to use the titles or phrases).

The inline styles are a pain, if you could figure out putting them in the header or using an attached CSS file that would be awesome.

Thanks for your help in this :)
webseitenfachmann replied on at Permalink Reply
webseitenfachmann
To fix the "style" html validation error I changed the view.php and put the styles directly with a style="bla" tag param into the according tags.

Thats dynamic and valid ;-)

concrete5 Environment Information

Browser User-Agent String

Hide Post Content

This will replace the post content with the message: "Content has been removed by an Administrator"

Hide Content

Request Refund

You have not specified a license for this support ticket. You must have a valid license assigned to a support ticket to request a refund.