Theme main controller

Permalink Browser Info Environment
Hi,
As I was checking your theme main controller, I noticed a numebr of things that I don't know if they can be considered as potential problems, or you did that intentionally. I would appreciate if you clarify on these:

1. The 'swapContent' method has been declared like this:
public function swapContent($options)

I guess it should have declared like this, as in '\concrete5-8.5.1\concrete\src\Package\ContentSwapper.php'
public function swapContent(Package $package, $options)


2. In the 'swapContent' method, in line 91, where you have specified xml file, you haven't check if current version is 8+ or not, and it alwayd import 'content_7.xml' and not 'content.xml'.

Type: Pre-Sale
Status: New
View Replies:

concrete5 Environment Information

.

Browser User-Agent String

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36 Edge/17.17134

Hide Post Content

This will replace the post content with the message: "Content has been removed by an Administrator"

Hide Content

Request Refund

You have not specified a license for this support ticket. You must have a valid license assigned to a support ticket to request a refund.