Custom templates and a suggestion regarding layout

Permalink Browser Info Environment
While i was creating some custom templates to tweak the gallery's look to fit my needs, a small suggestion to avoid design issues came into my mind.

Please take a look at the view.php:
there is the main container <div class="deluxe_image_gallery_container">.
All divs inside (class="deluxe_image_gallery_image"), containing the thumbnails, are floating left, but there is no final clearing element.
So i think, it would be useful to add something like

<div style="clear:both;"><!-- --></div>

before the closing </div> of <div class="deluxe_image_gallery_container">.

This would make sure that the gallery respects height / padding of parent containers and therefore should integrate more smoothly into all page layouts.

Michael

Type: Discussion
Status: New
okapi
View Replies:
jordanlev replied on at Permalink Reply
jordanlev
That is a good suggestion. I'm concerned that if I change it now though that it might cause the layout to break on sites that are currently using it the way it is. I'll definitely add it to my list and do some thorough testing to see if it won't be problematic whenever I'm ready for the next round of updates.

Thanks.

-Jordan
jordanlev replied on at Permalink Reply
jordanlev
Okay, I've added this clearing div in the latest update. Thanks for the feedback.

concrete5 Environment Information

Browser User-Agent String

Hide Post Content

This will replace the post content with the message: "Content has been removed by an Administrator"

Hide Content

Request Refund

You have not specified a license for this support ticket. You must have a valid license assigned to a support ticket to request a refund.