Monitor Reply

Support

PHP8.1 Error and Frontend Display Problem

Permalink Browser Info Environment April 04, 2023 at 8:05 PM

When saving the SEO settings from the Dashboard we are getting this error

Exception Occurred: public_html/packages/devoda_seo/single_pages/dashboard/devoda_seo/general.php:10 Undefined variable $errors (2)

We are also getting some weird output on the frontend of the site after upgrading to v9.1.3 and PHP8.1 (screenshot attached)

The source looks like this

<</head><body><p>!– Twitter Card data –>
<meta name="twitter:card" content="summary">
<meta name="twitter:description" content="Preco, LLC is an industrial contract manufacturer, we provide laser & die cutting equipment & contract manufacturing services. For more information call us today!">
<meta name="twitter:title" content="Die Cutting & Laser Equipment Solutions For Advanced Material...">
<!– Open Graph data –>
<meta property="og:locale" content="en_US">
<meta property="og:type" content="website">
<meta property="og:title" content="Die Cutting & Laser Equipment Solutions For Advanced Material Processing | Preco, LLC">
<meta property="og:description" content="Preco, LLC is an industrial contract manufacturer, we provide laser & die cutting equipment & contract manufacturing services. For more information call us today!">
<meta property="og:url" content="http://preco.russell.hutman.net/">
<meta property="og:site_name" content="Preco, LLC">
<meta property="og:updated_time" content="2023-03-10T13:44:57-05:00">
<meta property="article:published_time" content="2021-05-14T17:22:00-04:00">
<meta property="article:modified_time" content="2023-03-10T13:44:57-05:00">
<!– Schema.org markup for Google+ –>

1 Attachment

Type:	Ticket
Status:	In Progress

afixia replied on Apr 4, 2023 at 8:08 pm Permalink Reply

The output I posted got fixed, if you go tohttp://preco.russell.hutman.net/... and view source you can see the output that is causing the problem.

afixia replied on Apr 13, 2023 at 1:43 pm Permalink Reply

Hello, just wondering if there is any update for this. We need to get this corrected so we can launch the v9 upgrade for our site.

ramonleenders replied on Apr 14, 2023 at 6:55 am Permalink Reply

Hi there,

Just pushed update 1.6.4 - so update to that one to be able to work on PHP 8 and upwards.

As for the displaying issue of the meta data, it seems that this must have something to do with your current ConcreteCMS install. It is either a different package or the theme doing something to your HTML. This, since the "metaTags" event is fired which is a core ConcreteCMS thing. It could be that your theme or a package is placing these tags other than in the head... I have no other users having this issue and I don't see this issue on my installations nor on a clean install (PHP8.1 and lower and ConcreteCMS 9.1.1 and lower). Could you try the default theme and see if you have the same issues? If so, some other Add-On may be causing issues? I have too little info to be more precise on the issue you're having, so if you could try a thing or two here? :)

Kind regards
Ramon

afixia replied on Apr 28, 2023 at 2:21 pm Permalink Reply

Hello,

After updating to the latest version I am still seeing the weird display issue and I have checked the rest of my code and nothing else changes the metaTags.

When I look at the packages/devode_seo/src/DevodaSeo.php on lines 194, 230, and 286 my editor flags the "-" character with this message

The character U+2013 "–" could be confused with the ASCII character U+002d "-", which is more common in source code.

If I replace the dashes in there with a "--" then the display problem on the front end goes away. I don't know what the difference is or what changes, but that's what solved it for us.

Thanks.

ramonleenders replied on Apr 28, 2023 at 7:43 pm Permalink Reply

Hey,

If that fixes your issue, then all good. Have seen nor heard any other complaints, but if there is a workaround possible by defining something yourself, then why not. You can use anything you'd like, so indeed just change it or use a pipe ( | ) if you feel like it.

Have a good weekend! :)

Kind regards
Ramon

ramonleenders replied on Apr 28, 2023 at 7:46 pm Permalink Reply

Oh by the way, I may have misunderstood. Looking at the code just now, and thought you meant something else. Now when I replace the "-" character with another "-", it does say it is different. So I will change it and push it and you can tell me if that also fixes it on your end. No idea how this couldn't be an issue on any live sites I have, but it IS an issue for yours... Anyways, will push the update in a few minutes. Try that one and see if that fixes it :)

Devoda SEO

Support

PHP8.1 Error and Frontend Display Problem

Issue Reply

concrete5 Environment Information

Browser User-Agent String

Hide Post Content

Request Refund

Code

Delete Post