Click to Open/Click to Close
Permalink Browser Info Environment
We're loving your simple accordion!
There are a couple of instances where we've only got one accordion element on a page.
When the accordian element is open, there's no way to close it with out refreshing the page.
Is there a setting for click-to-close?
There are a couple of instances where we've only got one accordion element on a page.
When the accordian element is open, there's no way to close it with out refreshing the page.
Is there a setting for click-to-close?
| Type: | Discussion |
|---|---|
| Status: | New |
Hi Steven ::
Will certainly write a review.
Yes, we've got only one button element in this.
We were expecting to be able to click the title for open/close function, but we eventually found that there's a close "button" at the bottom of the div area.
You can see our use here at the bottom of our homepage.
http://stressdesign.com
The line that says Website Design, Brand Communications, and Identity Design is the accordion.
Thanks
Will certainly write a review.
Yes, we've got only one button element in this.
We were expecting to be able to click the title for open/close function, but we eventually found that there's a close "button" at the bottom of the div area.
You can see our use here at the bottom of our homepage.
http://stressdesign.com
The line that says Website Design, Brand Communications, and Identity Design is the accordion.
Thanks
Sorry for the delay in responding.
So I took a look at your site - and it's tricky to tell exactly what's going on without tinkering with code or the add-on settings. But here's something suggestions to try maybe?
I do see a JavaScript error on the page that says "Cannot read property 'top' of null". This may or may not be breaking the accordion script. Probably not, but it certainly could happen.
I do see in the JavaScript that is generated for the accordion that you have "collapsible" set to false which would prevent the accordion from being totally collapsible. The property in the block settings "Collapse accordion by default" should be set to "Yes". Is it?
Lastly, thanks so much for the review you wrote! I really appreciate you taking the time to do so!
So I took a look at your site - and it's tricky to tell exactly what's going on without tinkering with code or the add-on settings. But here's something suggestions to try maybe?
I do see a JavaScript error on the page that says "Cannot read property 'top' of null". This may or may not be breaking the accordion script. Probably not, but it certainly could happen.
I do see in the JavaScript that is generated for the accordion that you have "collapsible" set to false which would prevent the accordion from being totally collapsible. The property in the block settings "Collapse accordion by default" should be set to "Yes". Is it?
Lastly, thanks so much for the review you wrote! I really appreciate you taking the time to do so!
I set my collapse to "Yes" and it still doesn't collapse when you click a panel a second time.
Can you please send me a link to the site or PM it to me so I can take a look. My gut reaction is that there might be a JavaScript conflict somewhere. I'd be happy to take a look.
Having the same issue onhttps://www.betzpools.com/plan/faq/...
Attached is a screenshot of the settings and below is the code being output.
What I really want to have is the collapsing so when an open item it clicked again, it closes. Looks like the icons settings may not be outputted correctly either?
I would be more than happy to help test any possible new fixes for this issue.
P.S. - The site in question is using Simple Accordion version 0.9.2 and concrete5 version 5.6.2.1.
Attached is a screenshot of the settings and below is the code being output.
$(function() { $("#wc-accord-1989").accordion( { collapsible: false, autoHeight: false, fillSpace: false, active: false, icons: false, event: "click" }); });
What I really want to have is the collapsing so when an open item it clicked again, it closes. Looks like the icons settings may not be outputted correctly either?
I would be more than happy to help test any possible new fixes for this issue.
P.S. - The site in question is using Simple Accordion version 0.9.2 and concrete5 version 5.6.2.1.
Ugh. This seems to happen occasionally and is usually do to a site cache issue - at least it seems anyway. I've had difficult pinning down exactly when / why this happens. You have a couple of solutions here:
1. Modify the view.php file in the block and hard code these values - so, collapsible would be set to true, icons set to true, etc. The best way would probably be to create a new template for the block and set these values there.
2. Try turning off your cache while developing (remember to clear it, too). If you wouldn't mind, can you try this either way? Last time I encountered this it was the cause of the issue.
3. In the controller.php file in the blocks -> simple accordion directory, at the very top you'll see some variables to TRUE - mostly for cache settings. Please try changing these to false.
I apologize that you are getting this bug - as I said, it appears to occur randomly and haven't quite figured out how. In the latest release I've tried preventing any cache output from the block.
1. Modify the view.php file in the block and hard code these values - so, collapsible would be set to true, icons set to true, etc. The best way would probably be to create a new template for the block and set these values there.
2. Try turning off your cache while developing (remember to clear it, too). If you wouldn't mind, can you try this either way? Last time I encountered this it was the cause of the issue.
3. In the controller.php file in the blocks -> simple accordion directory, at the very top you'll see some variables to TRUE - mostly for cache settings. Please try changing these to false.
I apologize that you are getting this bug - as I said, it appears to occur randomly and haven't quite figured out how. In the latest release I've tried preventing any cache output from the block.
Dashboard > Systems & Settings > Cache & Speed Settings
I cleared the cache every time I changed an option when figuring out the above.
I tried the block template route but was still running into issues when Block Cache was enabled.
Since I want to generally have Block Cache on for the rest of the site, I was happy that fix 3, editing the controller.php file and disabling the cache just for Simple Accordion worked.
I can definitely live with this solution. :D
Thanks for the quick fix suggestions. Much appreciated. :D
Full Page Caching, no effect on or off. Overrides Cache, no effect on or off. Block Cache, fixes the issue when set to off.
I cleared the cache every time I changed an option when figuring out the above.
I tried the block template route but was still running into issues when Block Cache was enabled.
Since I want to generally have Block Cache on for the rest of the site, I was happy that fix 3, editing the controller.php file and disabling the cache just for Simple Accordion worked.
I can definitely live with this solution. :D
Thanks for the quick fix suggestions. Much appreciated. :D
ForestMist -
When did you purchase the add-on? I don't see you in my transaction history.
When did you purchase the add-on? I don't see you in my transaction history.
I'm a tech support person behind "Solutions" so you should see a purchase from that account on April 22, Order #106234. If it doesn't say "Soulutions" it might say "Dave Clark".
Don't worry, I would never ever ever pirate anything. That would break my own code of honor and on top of that... be extra super magically wrong since I'm a software developer myself. :D
Sorry about any confusion.
Don't worry, I would never ever ever pirate anything. That would break my own code of honor and on top of that... be extra super magically wrong since I'm a software developer myself. :D
Sorry about any confusion.
I would love it if you would write a review.
Anyway, the accordion element should close on click - do you only have one button element or is this with multiple?
I'd be more than happy to take a look if you wouldn't mind giving me a link. I use it all the time myself (in fact did last night on a site I'm working on) and click to close is the default setting.
Let me know.
Thanks!!