Monitor Reply

Support

Extra scripts and CSS in HEAD and footer when not logged in

Permalink Browser Info Environment October 30, 2015 at 10:49 AM

I am running 5.7.5.1. I was testing performance and noticed that in the HEAD and before the closing </body> there are a lot of unnecessary scripts and css being loaded when not in edit mode. They look necessary when adding and editing blocks, but on a live site they don't appear to do anything.

I narrowed it down to blocks created with Block Designer.

In the HEAD:

<link href="/updates/concrete5.7.5.1_remote_updater/concrete/css/jquery-ui.css" rel="stylesheet" type="text/css" media="all">
<link href="/updates/concrete5.7.5.1_remote_updater/concrete/css/file-manager.css" rel="stylesheet" type="text/css" media="all">
<link href="/updates/concrete5.7.5.1_remote_updater/concrete/css/select2.css" rel="stylesheet" type="text/css" media="all">

Before the closing </body>:

<script type="text/javascript" src="/updates/concrete5.7.5.1_remote_updater/concrete/js/events.js"></script>
<script type="text/javascript" src="/updates/concrete5.7.5.1_remote_updater/concrete/js/bootstrap/tooltip.js"></script>
<script type="text/javascript" src="/updates/concrete5.7.5.1_remote_updater/concrete/js/underscore.js"></script>
<script type="text/javascript" src="/updates/concrete5.7.5.1_remote_updater/concrete/js/backbone.js"></script>
<script type="text/javascript" src="/updates/concrete5.7.5.1_remote_updater/concrete/js/jquery-ui.js"></script>
<script type="text/javascript" src="http://mysite.com/ccm/assets/localization/jquery/ui/js"></script>
<script type="text/javascript" src="/updates/concrete5.7.5.1_remote_updater/concrete/js/select2.js"></script>
<script type="text/javascript" src="http://mysite.com/ccm/assets/localization/select2/js"></script>
<script type="text/javascript" src="http://mysite.com/ccm/assets/localization/core/js"></script>
<script type="text/javascript" src="/updates/concrete5.7.5.1_remote_updater/concrete/js/app.js"></script>
<script type="text/javascript" src="/updates/concrete5.7.5.1_remote_updater/concrete/js/jquery-fileupload.js"></script>
<script type="text/javascript" src="/updates/concrete5.7.5.1_remote_updater/concrete/js/file-manager.js"></script>

Anyone have insight into this and a fix? Thanks.

Type:	Discussion
Status:	Resolved

ramonleenders replied on Nov 3, 2015 at 2:51 am Permalink Reply

Hi there,

Do you have a specific example of a block that outputs extra scripts/styles? If so, post the config.json file please (or controller.php). I can take a look what could cause this.

Kind regards,

Ramon

darinronne replied on Nov 3, 2015 at 9:19 am Permalink Reply

I've attached the controller.php and config.json from one of my simpler blocks.

It's only field is a required image. And it outputs the image URL as a background-image on a div. The view.php also includes the "Disabled in Edit Mode" message.

Starting with a blank page, there are no extraneous scripts, then after inserting the above block (or any block created with Block Designer), I get all the extra scripts I listed in my initial post.

Thanks.

It wouldn't let me attach those files, so they are here:

config.json

{"view_css":"","view_js":"","block_name":"Page Intro Image","block_description":"","block_type_set":0,"cache_block_output_lifetime":"","block_install":0,"cache_block_record":1,"cache_block_output":1,"cache_block_output_on_post":1,"cache_block_output_for_registered_users":1,"table_prefix":"","interface_width":"400","interface_height":"500","fields":{"1":{"type":"image","label":"Image","slug":"image","required":"1","prefix":"<div class=\"page-intro__image\">","suffix":"<\/div>","class":"","link":"","link_class":"","output_src_only":"1","width":"","height":"","repeatable":""}},"block_handle":"tchc_page_intro_image","packages":{"block_designer":{"version":"1.2.13"},"block_designer_pro":{"version":"1.1.5"}}}

controller.php

<?php  namespace Application\Block\TchcPageIntroImage;
defined("C5_EXECUTE") or die("Access Denied.");
use Concrete\Core\Block\BlockController;
use Core;
use Loader;
use \File;
use Page;
class Controller extends BlockController
{
    public $helpers = array (
  0 => 'form',
);
    public $btFieldsRequired = array (
  0 => 'image',
);

Viewing 15 lines of 76 lines. View entire code block.

 
<?php  namespace Application\Block\TchcPageIntroImage;
 
defined("C5_EXECUTE") or die("Access Denied.");
 
use Concrete\Core\Block\BlockController;
use Core;
use Loader;
use \File;
use Page;
 
class Controller extends BlockController
{
    public $helpers = array (
  0 => 'form',
);
    public $btFieldsRequired = array (
  0 => 'image',
);
    protected $btExportFileColumns = array (
  0 => 'image',
);
    protected $btTable = 'btTchcPageIntroImage';
    protected $btInterfaceWidth = 400;
    protected $btInterfaceHeight = 500;
    protected $btCacheBlockRecord = true;
    protected $btCacheBlockOutput = true;
    protected $btCacheBlockOutputOnPost = true;
    protected $btCacheBlockOutputForRegisteredUsers = true;
    protected $btCacheBlockOutputLifetime = 0;
    protected $pkg = false;
 
    public function getBlockTypeDescription()
    {
        return t("");
    }
 
    public function getBlockTypeName()
    {
        return t("Page Intro Image");
    }
 
    public function on_start()
    {
        $al = \Concrete\Core\Asset\AssetList::getInstance();
        $this->requireAsset('core/file-manager');
    }
 
    public function view()
    {
        $db = \Database::get();
 
        if ($this->image && ($f = \File::getByID($this->image)) && is_object($f)) {
            $this->set("image", $f);
        }
        else {
            $this->set("image", false);
        }
    }
 
    public function add()
    {
        $this->set('btFieldsRequired', $this->btFieldsRequired);
    }
 
    public function edit()
    {
        $this->set('btFieldsRequired', $this->btFieldsRequired);
    }
 
    public function validate($args)
    {
        $e = Core::make("helper/validation/error");
        if (in_array("image", $this->btFieldsRequired) && (trim($args["image"]) == "" || !is_object(\File::getByID($args["image"])))){
            $e->add(t("The %s field is required.", "Image"));
        }
        return $e;
    }
 
    public function composer()
    {
        if (file_exists('application/blocks/tchc_page_intro_image/auto.js')) {
            $al = \Concrete\Core\Asset\AssetList::getInstance();
            $al->register('javascript', 'auto-js-tchc_page_intro_image', 'blocks/tchc_page_intro_image/auto.js', array(), $this->pkg);
            $this->requireAsset('javascript', 'auto-js-tchc_page_intro_image');
        }
        $this->edit();
    }
 
 
}

ramonleenders replied on Nov 3, 2015 at 9:52 am Permalink Reply

OK, I see the issue. In the on_start function, it requires the file manager.

Moving this line will remove 4 .js files and 2 .css files. I will fix this in an upcoming update. If you want to fix this manually, remove this line "$this->requireAsset('core/file-manager');" and copy this after:

public function add()
    {

And

public function edit()
    {

Kind regards,

Ramon

darinronne replied on Nov 3, 2015 at 2:16 pm Permalink Reply

Thanks. That fixed a couple of my blocks, but not the ones that have a repeater field.

public function on_start()
    {
        $al = \Concrete\Core\Asset\AssetList::getInstance();
        $al->register('css', 'repeatable-ft.form', 'blocks/tchc_image_video_slider/css_form/repeatable-ft.form.css', array(), $this->pkg);
        $al->register('javascript', 'handlebars', 'blocks/tchc_image_video_slider/js_form/handlebars-v4.0.2.js', array(), $this->pkg);
        $al->register('javascript', 'handlebars-helpers', 'blocks/tchc_image_video_slider/js_form/handlebars-helpers.js', array(), $this->pkg);$this->requireAsset('core/file-manager');
    }

I tried moving the three $al->register lines to the add() and edit() functions. Existing blocks still function, but can't add/edit them. The Edit modal doesn't appear.

The entire controller.php for a block with a repeater:

<?php  namespace Application\Block\TchcImageVideoSlider;
defined("C5_EXECUTE") or die("Access Denied.");
use Concrete\Core\Block\BlockController;
use Core;
use Loader;
use \File;
use Page;
use URL;
use \Concrete\Core\Editor\Snippet;
use Sunra\PhpSimple\HtmlDomParser;
use \Concrete\Core\Editor\LinkAbstractor;
class Controller extends BlockController
{
    public $helpers = array (
  0 => 'form',

Viewing 15 lines of 241 lines. View entire code block.

 
<?php  namespace Application\Block\TchcImageVideoSlider;
 
defined("C5_EXECUTE") or die("Access Denied.");
 
use Concrete\Core\Block\BlockController;
use Core;
use Loader;
use \File;
use Page;
use URL;
use \Concrete\Core\Editor\Snippet;
use Sunra\PhpSimple\HtmlDomParser;
use \Concrete\Core\Editor\LinkAbstractor;
 
class Controller extends BlockController
{
    public $helpers = array (
  0 => 'form',
);
    public $btFieldsRequired = array (
  0 => 'slide',
  'slide' => 
  array (
  ),
);
    protected $btExportFileColumns = array (
);
    protected $btExportTables = array (
  0 => 'btTchcImageVideoSlider',
  1 => 'btTchcImageVideoSliderSlideEntries',
);
    protected $btTable = 'btTchcImageVideoSlider';
    protected $btInterfaceWidth = 600;
    protected $btInterfaceHeight = 500;
    protected $btCacheBlockRecord = true;
    protected $btCacheBlockOutput = true;
    protected $btCacheBlockOutputOnPost = true;
    protected $btCacheBlockOutputForRegisteredUsers = true;
    protected $btCacheBlockOutputLifetime = 0;
    protected $pkg = false;
 
    public function getBlockTypeDescription()
    {
        return t("Slider for images and Youtube videos with descriptions.");
    }
 
    public function getBlockTypeName()
    {
        return t("Image/Video Slider");
    }
 
    public function on_start()
    {
        $al = \Concrete\Core\Asset\AssetList::getInstance();
        $al->register('css', 'repeatable-ft.form', 'blocks/tchc_image_video_slider/css_form/repeatable-ft.form.css', array(), $this->pkg);
        $al->register('javascript', 'handlebars', 'blocks/tchc_image_video_slider/js_form/handlebars-v4.0.2.js', array(), $this->pkg);
        $al->register('javascript', 'handlebars-helpers', 'blocks/tchc_image_video_slider/js_form/handlebars-helpers.js', array(), $this->pkg);$this->requireAsset('core/file-manager');
    }
 
    public function view()
    {
        $db = \Database::get();
        $slide = array();$slide_items = $db->GetAll('SELECT * FROM btTchcImageVideoSliderSlideEntries WHERE bID = ? ORDER BY sortOrder', array($this->bID));
        foreach($slide_items as $slide_item_k => &$slide_item_v) {            
        if (isset($slide_item_v['image']) && trim($slide_item_v['image']) != "" && ($f = \File::getByID($slide_item_v['image'])) && is_object($f)) {
            $slide_item_v['image'] = $f;
        }
        else {
            $slide_item_v['image'] = false;
        }
 
 
            $slide_item_v["description_1"] = isset($slide_item_v["description_1"]) ? LinkAbstractor::translateFrom($slide_item_v["description_1"]) : null;
        }
        $this->set('slide_items', $slide_items);$this->set('slide', $slide);
 
        $this->requireAsset('javascript', 'core/lightbox');
        $this->requireAsset('css', 'core/lightbox');
    }
 
    public function delete()
    {
        $db = \Database::get();
        $db->delete('btTchcImageVideoSliderSlideEntries', array('bID' => $this->bID));
        parent::delete();
    }
 
    public function duplicate($newBID)
    {
        $db = \Database::get();
        $slide_items = $db->GetAll('SELECT * FROM btTchcImageVideoSliderSlideEntries WHERE bID = ? ORDER BY sortOrder', array($this->bID));
        foreach ($slide_items as $slide_item) {
            unset($slide_item['id']);
            $slide_item['bID'] = $newBID;
            $db->insert('btTchcImageVideoSliderSlideEntries', $slide_item);
        }
        parent::duplicate($newBID);
    }
 
    public function add()
    {
        $this->requireAsset('core/sitemap');
        $this->requireAsset('javascript', 'handlebars');
        $this->requireAsset('javascript', 'handlebars-helpers');
        $this->requireAsset('css', 'repeatable-ft.form');
        $this->set('identifier', new \Concrete\Core\Utility\Service\Identifier());
        $slide = array();
        $this->set('slide_items', array());
        $this->requireAsset('redactor');
        $this->requireAsset('core/file-manager');
        $this->set('slide', $slide);
        $this->set('btFieldsRequired', $this->btFieldsRequired);
    }
 
    public function edit()
    {
        $db = \Database::get();
        $this->requireAsset('core/sitemap');
        $this->requireAsset('javascript', 'handlebars');
        $this->requireAsset('javascript', 'handlebars-helpers');
        $this->requireAsset('css', 'repeatable-ft.form');
        $this->set('identifier', new \Concrete\Core\Utility\Service\Identifier());
        $slide = array();
        $slide_items = $db->GetAll('SELECT * FROM btTchcImageVideoSliderSlideEntries WHERE bID = ? ORDER BY sortOrder', array($this->bID));
        foreach ($slide_items as &$slide_item) {
            if(!File::getByID($slide_item['image'])) {
                unset($slide_item['image']);
            }
        }
        $this->requireAsset('redactor');
        $this->requireAsset('core/file-manager');
        $this->set('description_1', LinkAbstractor::translateFromEditMode($this->description_1));
        $this->set('slide', $slide);
        $this->set('slide_items', $slide_items);
        $this->set('btFieldsRequired', $this->btFieldsRequired);
    }
 
    public function save($args)
    {
        $db = \Database::get();
        $rows = $db->GetAll('SELECT * FROM btTchcImageVideoSliderSlideEntries WHERE bID = ? ORDER BY sortOrder', array($this->bID));
        $slide_items = isset($args['slide']) && is_array($args['slide']) ? $args['slide'] : array();
        $queries = array();
        if (!empty($slide_items)) {
            $i = 0;
            foreach ($slide_items as $slide_item) {
                $data = array(
                    'sortOrder' => $i + 1,
                );
                if (isset($slide_item['image']) && trim($slide_item['image']) != '') {
                    $data['image'] = trim($slide_item['image']);
                } else {
                    $data['image'] = null;
                }if (isset($slide_item['youtubeID']) && trim($slide_item['youtubeID']) != '') {
                    $data['youtubeID'] = trim($slide_item['youtubeID']);
                } else {
                    $data['youtubeID'] = null;
                }if (isset($slide_item['title']) && trim($slide_item['title']) != '') {
                    $data['title'] = trim($slide_item['title']);
                } else {
                    $data['title'] = null;
                }$data['description_1'] = isset($slide_item['description_1']) ? LinkAbstractor::translateTo($slide_item['description_1']) : null;
                if (isset($rows[$i])) {
                    $queries['update'][$rows[$i]['id']] = $data;
                    unset($rows[$i]);
                } else {
                    $data['bID'] = $this->bID;
                    $queries['insert'][] = $data;
                }
                $i++;
            }
        }
        if (!empty($rows)) {
            foreach ($rows as $row) {
                $queries['delete'][] = $row['id'];
            }
        }
        if (!empty($queries)) {
            $db = \Database::get();
            foreach ($queries as $type => $values) {
                if (!empty($values)) {
                    switch ($type) {
                        case 'update':
                            foreach ($values as $id => $data) {
                                $db->update('btTchcImageVideoSliderSlideEntries', $data, array('id' => $id));
                            }
                            break;
                        case 'insert':
                            foreach ($values as $data) {
                                $db->insert('btTchcImageVideoSliderSlideEntries', $data);
                            }
                            break;
                        case 'delete':
                            foreach ($values as $value) {
                                $db->delete('btTchcImageVideoSliderSlideEntries', array('id' => $value));
                            }
                            break;
                    }
                }
            }
        }
        parent::save($args);
    }
 
    public function validate($args)
    {
        $e = Core::make("helper/validation/error");
        $slideEntriesMin = 0;
        $slideEntriesMax = 0;
        $slideEntriesErrors = 0;
        $slide = array();
        if (isset($args['slide']) && is_array($args['slide']) && !empty($args['slide'])) {
            if ($slideEntriesMin >= 1 && count($args['slide']) < $slideEntriesMin) {
                $e->add(t("The %s field requires at least %s entries, %s entered.", "Slide", $slideEntriesMin, count($args['slide'])));
                $slideEntriesErrors++;
            }
            if ($slideEntriesMax >= 1 && count($args['slide']) > $slideEntriesMax) {
                $e->add(t("The %s field is set to a maximum of %s entries, %s entered.", "Slide", $slideEntriesMax, count($args['slide'])));
                $slideEntriesErrors++;
            }
            if ($slideEntriesErrors == 0) {
                foreach ($args['slide'] as $slide_k => $slide_v) {
                    if (is_array($slide_v)) {
                        if (in_array("image", $this->btFieldsRequired['slide']) && (!isset($slide_v['image']) || trim($slide_v['image']) == "" || !is_object(\File::getByID($slide_v['image'])))){
           $e->add(t("The %s field is required (%s, row #%s).", "Image", "Slide", $slide_k));
        }
                        if (in_array("youtubeID", $this->btFieldsRequired['slide']) && (!isset($slide_v['youtubeID']) || trim($slide_v['youtubeID']) == "")) {
                            $e->add(t("The %s field is required (%s, row #%s).", "Youtube ID", "Slide", $slide_k));
                        }
                        if (in_array("title", $this->btFieldsRequired['slide']) && (!isset($slide_v['title']) || trim($slide_v['title']) == "")) {
                            $e->add(t("The %s field is required (%s, row #%s).", "Title", "Slide", $slide_k));
                        }
                        if (in_array("description_1", $this->btFieldsRequired['slide']) && (!isset($slide_v['description_1']) || trim($slide_v['description_1']) == "")) {
                            $e->add(t("The %s field is required (%s, row #%s).", "Description", "Slide", $slide_k));
                        }
                        } else {
                        $e->add(t("The values for the %s field, row #%s, are incomplete.", 'Slide', $slide_k));
                    }
                }
            }
        } else {
            if ($slideEntriesMin >= 1) {
                $e->add(t("The %s field requires at least %s entries, none entered.", "Slide", $slideEntriesMin));
            }
        }
        return $e;
    }
 
    public function composer()
    {
        if (file_exists('application/blocks/tchc_image_video_slider/auto.js')) {
            $al = \Concrete\Core\Asset\AssetList::getInstance();
            $al->register('javascript', 'auto-js-tchc_image_video_slider', 'blocks/tchc_image_video_slider/auto.js', array(), $this->pkg);
            $this->requireAsset('javascript', 'auto-js-tchc_image_video_slider');
        }
        $this->edit();
    }
 
 
}

darinronne replied on Nov 3, 2015 at 2:35 pm Permalink Reply

Nevermind. I misread the code.

$this->requireAsset('core/file-manager');

was on the same line as

$al->register('javascript', 'handlebars-helpers', 'blocks/tchc_home_slider/js_form/handlebars-helpers.js', array(), $this->pkg);

and it is already included in the add() and edit() functions. Just had to remove it from on_start().

Thanks again for all your help.

ramonleenders replied on Nov 3, 2015 at 3:40 pm Permalink Reply

So you got it all working now, or you still need help?

From what I've seen only the "File", "Image" and "Repeatable" field type have these issues (if you can call them issues haha). I will update these anytime soon! Sorry for the inconvenience so far..

Kind regards,

Ramon

ramonleenders replied on Nov 5, 2015 at 3:04 am Permalink Reply

Hi there,

Version 1.3.4 should fix the problem for block you create in the future (so no more manual editing required).

Kind regards,

Ramon

darinronne replied on Nov 5, 2015 at 2:56 pm Permalink Reply

Did you also apply the fix to Block Designer Pro and the Repeatable field? I didn't see it in the version history.

ramonleenders replied on Nov 5, 2015 at 6:07 pm Permalink Reply

Registering assets is not a biggy, the files aren't being loaded. If you are requiring assets, that's what causes to actually load it in the head and/or footer. I spotted this later, so this doesn't need fixing I assume. Or do you think otherwise? Open to any feedback/comments!

Block Designer

Support

Extra scripts and CSS in HEAD and footer when not logged in

Issue Reply

concrete5 Environment Information

Browser User-Agent String

Hide Post Content

Request Refund

Code

Delete Post