Small change for php7 compatibility
Permalink Browser Info Environment
For anyone updating to php7:
core_commerce_gift_cards/models/core_commerce/payment/methods/gift_cards/controller.php
(Anyone implementing this on a site will also need to update eCommerce, and that has a lot of php7 incompatibilities)
core_commerce_gift_cards/models/core_commerce/payment/methods/gift_cards/controller.php
Line:15 public function on_start($task=null) { // php7 compatibility
(Anyone implementing this on a site will also need to update eCommerce, and that has a lot of php7 incompatibilities)
| Type: | Pre-Sale |
|---|---|
| Status: | In Progress |
Thanks a lot John for these!
I cannot find an official release of legacy concrete5 that supports PHP7.2. The latest available version (5.6.3.5) still seems to ship with the "Object" class, although the changes have been made in the GitHub version.
I guess these changes need to be implemented by hand in case someone still needs to maintain a legacy site.
I cannot find an official release of legacy concrete5 that supports PHP7.2. The latest available version (5.6.3.5) still seems to ship with the "Object" class, although the changes have been made in the GitHub version.
I guess these changes need to be implemented by hand in case someone still needs to maintain a legacy site.
c5.6 core php7.2 compatibility is on the 5.6 github and Portland Labs have promised to release it as 5.6.4 as an end of life release.
All the class name changes are not backward compatible in themselves. But adding the code below then makes it backward compatible
All the class name changes are not backward compatible in themselves. But adding the code below then makes it backward compatible
if(!class_exists('ConcreteObject') && class_exists('Object')){ class ConcreteObject extends Object {} }
packages/core_commerce_gift_cards/controller.php