BASE_SSL_URL or BASE_URL_SSL?

Permalink Browser Info Environment
Hi

I just looked through the code for this addon, and in models/jbx_force_ssl.php I found the following bit of code:
if (!defined(BASE_SSL_URL)) {
    $base_ssl_url = preg_replace('@http://@', 'https://', BASE_URL);
} else {
    $base_ssl_url = BASE_SSL_URL;
}

From what I have seen, the HTTPS URL to a website is defined in the constant named BASE_URL_SSL instead of BASE_SSL_URL, so I doubt that BASE_SSL_URL will ever be defined.

/Jeppe

Type: Discussion
Status: New
View Replies: View Best Answer
jeppet replied on at Permalink Reply
Oh, I just noticed the same is the case for all the three files under the autonav folder.
jbx replied on at Permalink Best Answer Reply
jbx
When I originally wrote this addon, I wasn't taking into account the C5 BASE_URL_SSL. The idea for this, was that if you wanted to use a completely different URL for SSL, then you could define it yourself in the site.php. I've altered it slightly in a newer version (not yet released) to JBX_SSL_URL to make it less ambiguous.

Make sense?

Jon
jeppet replied on at Permalink Reply
Sure, it makes more sense then. On first glance I just thought it was a mistake, and hence why I thought I would report it here.

concrete5 Environment Information

Browser User-Agent String

Hide Post Content

This will replace the post content with the message: "Content has been removed by an Administrator"

Hide Content

Request Refund

You have not specified a license for this support ticket. You must have a valid license assigned to a support ticket to request a refund.