Error after upgrade to 3.0 on Concrete5 8.2.1
Permalink Browser Info Environment
After having upgraded to v. 3.0 on Concrete5 8.2.1, i'm getting the following error:
No caches enabled, cache cleared after upgrade.
Thank you,
Michael
createPaginationObject Methode existiert nicht für die Klasse Concrete\Package\PagePickerPlus\Src\Page\PageList
No caches enabled, cache cleared after upgrade.
Thank you,
Michael
Type: | Pre-Sale |
---|---|
Status: | In Progress |
I just installed 8.2.1 and can confirm the bug. They changed something again with the pagination. I am still testing a bug fix which is basically just reverting the change I made in the the Page Picker Plus version 3. You can temporarily fix the bug by commenting out the method 'createPaginationObject' in the class Concrete\Package\PagePickerPlus\Src\Page\PageList which you can find in the folder /packages/page_picker_plus/src/Page.
I will do some more tests and release a new version for Concrete 8.2.1. Let's just hope they stop changing the pagination in next versions of Concrete.
Commented out code:
I will do some more tests and release a new version for Concrete 8.2.1. Let's just hope they stop changing the pagination in next versions of Concrete.
Commented out code:
<?php namespace Concrete\Package\PagePickerPlus\Src\Page; use \Concrete\Core\Page\PageList as Base; use \Pagerfanta\Adapter\DoctrineDbalAdapter; use \Concrete\Core\Search\Pagination\Pagination; use \Concrete\Core\Search\Pagination\PagerPagination; use \Concrete\Package\PagePickerPlus\Block\PagePickerPlus\Controller; /** * This PageList returns pages for a PagePicker block. * @author Justin van Schaick */ class PageList extends Base { /** * The ID of the block to return the pages for * @var int
Viewing 15 lines of 64 lines. View entire code block.
Thank you for your speedy support!
All these changes and changes back with every new version make life difficult for add-on developers...
All these changes and changes back with every new version make life difficult for add-on developers...
No problem ;)
I did some more tests and everything works as it should now. I just released 3.0.1. Everything should work properly again. I basically just reverted the bug fix made in 3.0.
It is hard indeed, I hardly make any money at all with this add-on and I still have to offer support and then a while ago this guy created a free addon for the marketplace which basically does most of what the normal Page Picker does. Thanks to him I hardly sell anything anymore.
Concrete 8.2.1 still uses the paginator class that created the error in 8.2 but they might have fixed the issue because the bug from 8.2 seems to be gone. But they are moving the paginator instantiation to a factory class which makes it harder for me to create overrides if something breaks. But I'll tackle that issue when we get there :)
I did some more tests and everything works as it should now. I just released 3.0.1. Everything should work properly again. I basically just reverted the bug fix made in 3.0.
It is hard indeed, I hardly make any money at all with this add-on and I still have to offer support and then a while ago this guy created a free addon for the marketplace which basically does most of what the normal Page Picker does. Thanks to him I hardly sell anything anymore.
Concrete 8.2.1 still uses the paginator class that created the error in 8.2 but they might have fixed the issue because the bug from 8.2 seems to be gone. But they are moving the paginator instantiation to a factory class which makes it harder for me to create overrides if something breaks. But I'll tackle that issue when we get there :)
Thank you so much!
Cheers,
Michael
Cheers,
Michael
I'm going to debug it now and get back to you when I find the problem.