Site broke after upgrading to 5.8

Permalink Browser Info Environment
I am trying to upgrade my concrete5 installation and am running into this error:

Whoops \ Exception \ ErrorException (E_WARNING)
HELP
Declaration of Concrete\Package\PagePickerPlus\Block\PagePickerPlus\Controller::save(array $args) should be compatible with Concrete\Core\Block\BlockController::save($args)
/public_html/packages/page_picker_plus/blocks/page_picker_plus/controller.php
echo $output;
}else {
http_response_code(404);
}

exit();
}
}

I also cannot find how to download the most current version of PagePicker+ ... I think my install was still on v1 with no option to update the plugin via the dashboard.

Type: Pre-Sale
Status: In Progress
leviticus
View Replies:
Justin1978 replied on at Permalink Reply
Justin1978
Hi Leveticus,

I'm sorry to hear about the bug. It's caused by the typeasting of $args as array (array $args) that isn't compatible with the method it's overriding from Concrete that doesn't typecast $args. I fixed this bug and this was in version 2.0 according to my changelogs but when I browse through the files I still see the array typecast in my repository, which is strange.

I will sort things out as soon as I get back from work this evening and get back to you. For now just removing the array typecast should be enough to fix the bug and get your site working again. I'm not sure if you are familiar wiith code but all you have to do is open the file /packages/page_picker_plus/blocks/page_page_plus/controller.php and remove the 'array' keyword from the method.

So this:
/**
     * {@inheritDoc}
     */
    public function save(array $args){


Becomes this:
/**
     * {@inheritDoc}
     */
    public function save($args){
leviticus replied on at Permalink Reply
leviticus
Thanks so much for your quick reply! Your fixed worked and I was able to finish my upgrade to Concrete 5.8 as well as update Page Picker+ to v 3.1.3.
Justin1978 replied on at Permalink Reply
Justin1978
Glad I could help and it all worked out. I'm double checking the older versions of the add-ons just to be sure. Do you know what version of the add-on you had?
Justin1978 replied on at Permalink Reply
Justin1978
I just figured out you were using version 1.2 of the add-on. The problem was fixed in 2.0. I just released 1.2.1 that fixes the bug for version 1.2 for anyone else that has that version.

My apologies for the inconvenience it caused and thanks for reporting the bug!

concrete5 Environment Information

Concrete5 Version 5.7.5.13

Browser User-Agent String

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/604.5.6 (KHTML, like Gecko) Version/11.0.3 Safari/604.5.6

Hide Post Content

This will replace the post content with the message: "Content has been removed by an Administrator"

Hide Content

Request Refund

You may not request a refund that is not currently owned by you.