Facebook share count issue resloved URL

Permalink Browser Info Environment
I was finding that the social share button count for facebook was stuck on 1.1k
As much as i like to dream that just wasn't the right count.

The actual url used in facebook button share was of the raw "index.php?cid=" variety.

I think it should be changed to the real url as facebook likes natural url or encoded urls. So on skybluesofa_social_share/view.php line 249 i changed this:
if ($sharedNetwork['url']) {
                                 echo ' data-href="' . $sharedNetwork['url'] . '"';
                              }

to:
if ($sharedNetwork['url']) {
  echo ' data-href="' . $sbsss_pageURL . '"';
}

NB '$sbsss_pageURL' is set n the controller
Now the count works ok and the shared url is the pretty one

Type: Discussion
Status: In Progress
alanski
View Replies:
SkyBlueSofa replied on at Permalink Reply
SkyBlueSofa
I've updated the controller to assign the current page url to $sharedNetwork['url'] when a web address isn't explicitly given in the block settings.

I'll be pushing the update later today.

concrete5 Environment Information

#

Browser User-Agent String

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/39.0.2171.71 Safari/537.36

Hide Post Content

This will replace the post content with the message: "Content has been removed by an Administrator"

Hide Content

Request Refund

You may not request a refund that is not currently owned by you.