float: left; on container
Permalink Browser Info Environment
Hey Jordan,
Just wanted to point out that you're putting float: left on your container of both sortable and your simple gallery container. This can cause a few little issues.
One example is, say I have the image gallery, and then some content after it. The next block I put after will but up to the bottom of it, regardless of if the next block has margin or not. So I can't space say a paragraph of text after the gallery.
May I suggest not having a float, and either use overflow: auto; to contain the image divs, or adding an empty div with a clear: float; after all the image divs?
Just wanted to point out that you're putting float: left on your container of both sortable and your simple gallery container. This can cause a few little issues.
One example is, say I have the image gallery, and then some content after it. The next block I put after will but up to the bottom of it, regardless of if the next block has margin or not. So I can't space say a paragraph of text after the gallery.
May I suggest not having a float, and either use overflow: auto; to contain the image divs, or adding an empty div with a clear: float; after all the image divs?
| Type: | Discussion |
|---|---|
| Status: | New |
that's assuming that the people using the add-on are designers. :)
I'm not saying to remove the float on the individual divs containing the image, I'm just talking about the container that contains the items.
overflow: auto; instead on the container solves it most of the time. a clearing div would surefire solve it.
I understand there's the reluctance of having an empty clearing div. Sometimes it's a necessary evil though.
And you're correct though. A lot of designers would just fix it on their own. A lot of site owners however, can't do that, or don't notice.
Anyways, just something I came across - do what you will with it :)
I'm not saying to remove the float on the individual divs containing the image, I'm just talking about the container that contains the items.
overflow: auto; instead on the container solves it most of the time. a clearing div would surefire solve it.
I understand there's the reluctance of having an empty clearing div. Sometimes it's a necessary evil though.
And you're correct though. A lot of designers would just fix it on their own. A lot of site owners however, can't do that, or don't notice.
Anyways, just something I came across - do what you will with it :)
Thanks for the thoughtful feedback -- much appreciated.
I will have to think about this. I don't think I want to remove the float (because I think that is the simplest way to make things line up), but perhaps adding a clearing div at the bottom makes sense (although I'm not sure about this either because it bothers me when there's extra tags in block templates -- e.g. how the HTML block wraps the contents in a div -- argh!)
My thought with these addons is that usually their styles will be overridden in the theme CSS anyway. And honestly you're the only person who's ever mentioned this issue, and you are obviously capable of understanding how to override css styles, so I'm not sure this is actually an issue for people that want to use it out of the box without and CSS knowledge.
Will put more thought into it for sure though -- thanks again.
-Jordan